Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove productive mixin & apply expressive tokens to Carbon for IBM.com components #4748

Closed
14 tasks done
oliviaflory opened this issue Dec 18, 2020 · 0 comments
Closed
14 tasks done
Assignees
Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package priority: medium
Milestone

Comments

@oliviaflory
Copy link
Contributor

oliviaflory commented Dec 18, 2020

User Story

As a [user role below]:

DDS developer

I need to:

update all Carbon for IBM.com components that use the productive tokens to use expressive theme tokens and remove the productive mixin

so that :

components use one type scale and are more consistent for our adopters

Additional information

Here is a list of the components that need updating and which token they should use with the expressive theme applied.

  • Leaving IBM (bx--leaving-ibm__text) --> $label-01

  • call out data (bx--callout-data__source) --> $caption-01

  • callout with media (bx--image__caption) - uses the productive zoning mixin --> $caption-01

  • Card (bx--card__eyebrow - both use productive zoning mixin --> $label-01

  • Card bx--card__video bx--card__footer span --> remove styling that is not being applied:

.#{$prefix}--card__video {
      .#{$prefix}--card__footer span {
        color: $text-02;
        @include use-carbon-productive-tokens();
        @include carbon--type-style('body-short-01');
      }
    } 
  • image with caption (bx--image__caption) - uses the productive zoning mixin --> $caption-01

  • locale modal (bx--modal-header__label) - uses the productive zoning mixin --> $label-01

  • content item horizontal (bx--content-item-horizontal__item--eyebrow) - uses the productive zoning mixin --> $label-01

  • video player (bx--video-player__video-caption) - uses the productive zoning mixin --> $caption-01

  • locale modal (bx--locale-modal__search-text) - uses the productive zoning mixin --> $heading-02

  • logo grid (bx--content-block__cta .bx--card__heading) - uses the productive zoning mixin --> check if there is outdated code

Note: we will not be removing the productive mixin from the mega menu, decided in #4341

Acceptance criteria

  • Productive mix-in is removed from all components listed above
  • no breaking changes have been introduced
  • Designer (Olivia) reviewed all changes in preview
@oliviaflory oliviaflory added dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package labels Dec 18, 2020
@annawen1 annawen1 added package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package and removed package: styles Work necessary for the Carbon for IBM.com styles package labels Dec 18, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 21-02 milestone Jan 4, 2021
kodiakhq bot pushed a commit that referenced this issue Jan 27, 2021
…place with expressive tokens (#4957)

### Related Ticket(s)

Remove productive mixin & apply expressive tokens to Carbon for IBM.com components #4748

### Description

Remove productive mixin from components (leave as is in the masthead) styles and replace with expressive tokens

### Changelog

**Changed**

- swap tokens with expressive tokens

**Removed**

- unused card video footer styles
- edit the LogoGrid card props to set card heading as intended from the LogoGrid design specs (https://ibm.ent.box.com/file/661851053906)
- productive token mixin use from components other than masthead

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this issue Feb 22, 2021
…place with expressive tokens (carbon-design-system#4957)

### Related Ticket(s)

Remove productive mixin & apply expressive tokens to Carbon for IBM.com components carbon-design-system#4748

### Description

Remove productive mixin from components (leave as is in the masthead) styles and replace with expressive tokens

### Changelog

**Changed**

- swap tokens with expressive tokens

**Removed**

- unused card video footer styles
- edit the LogoGrid card props to set card heading as intended from the LogoGrid design specs (https://ibm.ent.box.com/file/661851053906)
- productive token mixin use from components other than masthead

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants