Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(percy): skip percy testing of the fade component #4955

Merged

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

The fade component storybook snapshots are causing false positives in our automated visual regression tests. As this is not a necessary test for visual regression, this PR adds the flag to skip these tests in Percy.

Changelog

Changed

  • fade component percy configuration

@ibmdotcom-bot
Copy link
Contributor

Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jeffchew!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 20, 2021
@ibmdotcom-bot
Copy link
Contributor

@kodiakhq kodiakhq bot merged commit 5202deb into carbon-design-system:master Jan 20, 2021
@ibmdotcom-bot
Copy link
Contributor

@jeffchew jeffchew deleted the chore/dotcomshell-percy branch February 8, 2021 22:13
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
…-system#4955)

### Related Ticket(s)

No related issue

### Description

The fade component storybook snapshots are causing false positives in our automated visual regression tests. As this is not a necessary test for visual regression, this PR adds the flag to skip these tests in Percy.

### Changelog

**Changed**

- fade component percy configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants