chore(fade-in-out): added percy skips #4954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview created for package Built with commit: 0b5fff42a9062c5f81715565b7a3c3fdab606d0c |
|
Deploy preview created for package Built with commit: 0b5fff42a9062c5f81715565b7a3c3fdab606d0c |
|
Deploy preview created for package Built with commit: 0b5fff42a9062c5f81715565b7a3c3fdab606d0c |
|
Closing since #4955 also adds the percy skip to Web Components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
none
Description
The FadeInOut component story gets the content from the DotcomShell story, but Percy is detecting changes within the FadeInOut story that may have to do with the fade animation. Since these two stories are the same, we will now be skipping these.
Changelog
New
FadeInOutcomponent story