Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(carousel): remove page-size knob #4921

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 19, 2021

Related Ticket(s)

Refs #4918.

Description

Removes page-size knob from the stories of carousel given user may get too large number there where our demo in storybook will look very weird.

Changelog

Removed

  • page-size knob in carousel story.

Removes `page-size` knob from the stories of carousel given user may
get too large number there where our demo in storybook will look very
weird.

Refs carbon-design-system#4918.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Jan 19, 2021
@asudoh asudoh changed the base branch from master to release/v1.15.0 January 19, 2021 15:31
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 19, 2021
@kodiakhq kodiakhq bot merged commit a7f36a6 into carbon-design-system:release/v1.15.0 Jan 19, 2021
@asudoh asudoh deleted the carousel-knob branch January 20, 2021 00:23
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
### Related Ticket(s)

Refs carbon-design-system#4918.

### Description

Removes `page-size` knob from the stories of carousel given user may get too large number there where our demo in storybook will look very weird.

### Changelog

**Removed**

- `page-size` knob in carousel story.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants