Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web & React: Carousel - On Mobile, "Page size" as 6, user can not see all the cards and pagination does not work #4918

Closed
Praveen-sr opened this issue Jan 19, 2021 · 0 comments
Closed

Web & React: Carousel - On Mobile, "Page size" as 6, user can not see all the cards and pagination does not work #4918

Praveen-sr opened this issue Jan 19, 2021 · 0 comments
Assignees
@asudoh
Labels
bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Milestone
Sprint 21-02

Comments

@Praveen-sr
Copy link

Detailed description

Issue:

  1. On Mobile, Page size as 6, user can not see all the cards and pagination does not work.
  2. On tab and desktop - Page size as 6, the alignment of the cards is not right.

Additional information

Car1.gif

image.png
@Praveen-sr Praveen-sr added bug Something isn't working severity 2 Affects major functionality, has a workaround labels Jan 19, 2021
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Jan 19, 2021
@asudoh
docs(carousel): remove page-size knob
ee78638 
Removes `page-size` knob from the stories of carousel given user may
get too large number there where our demo in storybook will look very
weird.

Refs carbon-design-system#4918.
@asudoh asudoh mentioned this issue Jan 19, 2021
Merged
@asudoh asudoh assigned asudoh and unassigned jeffchew, ljcarot, ghost and RobertaJHahn Jan 19, 2021
@RobertaJHahn RobertaJHahn added this to the Sprint 21-02 milestone Jan 19, 2021
@RobertaJHahn RobertaJHahn added package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Airtable Done dev Needs some dev work labels Jan 19, 2021
kodiakhq bot pushed a commit that referenced this issue Jan 19, 2021
@asudoh
docs(carousel): remove page-size knob (#4921)
a7f36a6 
### Related Ticket(s)

Refs #4918.

### Description

Removes `page-size` knob from the stories of carousel given user may get too large number there where our demo in storybook will look very weird.

### Changelog

**Removed**

- `page-size` knob in carousel story.
@asudoh asudoh mentioned this issue Jan 20, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this issue Feb 22, 2021
@asudoh @IgnacioBecerra
docs(carousel): remove page-size knob (carbon-design-system#4921)
150766e 
### Related Ticket(s)

Refs carbon-design-system#4918.

### Description

Removes `page-size` knob from the stories of carousel given user may get too large number there where our demo in storybook will look very weird.

### Changelog

**Removed**

- `page-size` knob in carousel story.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asudoh asudoh

Labels
bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Projects
None yet
Milestone
Sprint 21-02
Development

No branches or pull requests
5 participants
@asudoh @jeffchew @ljcarot @RobertaJHahn @Praveen-sr