Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead): add aria-label #4812

Merged
merged 4 commits into from
Jan 6, 2021
Merged

fix(masthead): add aria-label #4812

merged 4 commits into from
Jan 6, 2021

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#4773

Description

Missing aria label for masthead-search combobox.

Changelog

New

  • add aria-label to combobox

@ariellalgilmore ariellalgilmore added the package: web components Work necessary for the IBM.com Library web components package label Jan 5, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4812/index.html

Built with commit: ca64afb545172cc2c5f25558e8f28c36072707ed

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4812/index.html

Built with commit: ca64afb545172cc2c5f25558e8f28c36072707ed

asudoh
asudoh approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @ariellalgilmore!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 5, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4812/index.html

Built with commit: ca64afb545172cc2c5f25558e8f28c36072707ed

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Jan 5, 2021
@kodiakhq kodiakhq bot merged commit 700ada5 into carbon-design-system:master Jan 6, 2021
@ariellalgilmore ariellalgilmore deleted the fix/masthead-search_label branch January 6, 2021 01:58
@jeffchew jeffchew mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariellalgilmore @ibmdotcom-bot @asudoh