Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web component: Masthead L1 - Search edit combo list box - No label for this control.  #4773

Closed
Praveen-sr opened this issue Dec 23, 2020 · 2 comments
Closed

Web component: Masthead L1 - Search edit combo list box - No label for this control.  #4773

Praveen-sr opened this issue Dec 23, 2020 · 2 comments
Assignees
@ariellalgilmore
Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Milestone
Sprint 21-01

Comments

@Praveen-sr
Copy link

Detailed description

On JAWS FF/Voiceover iPhone

Issue: Search edit combo list box - No label for this control. 

Expected: give label as "search"

Additional information
@Praveen-sr Praveen-sr added accessibility Has accessibility requirement bug Something isn't working severity 2 Affects major functionality, has a workaround labels Dec 23, 2020
@RobertaJHahn RobertaJHahn added Airtable Done dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package labels Dec 23, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 21-01 milestone Dec 23, 2020
@ariellalgilmore ariellalgilmore self-assigned this Jan 4, 2021
@ariellalgilmore
Copy link
Member

@Praveen-sr can you re-test this? Looks like this is working now.

@Praveen-sr
Copy link
Author

@ariellalgilmore Re tested this on JAWS FF/Voiceover iPhone, Not fixed.

Placeholder is provided instead of a label. Place holder cannot be considered as an replacement for an Accessible Name. And also Because it is not rendered reliably across the different versions of Screen readers and Browsers. We recommend using aria-label here.
Please refer the following link on the same.
https://www.w3.org/WAI/tutorials/forms/instructions/

@ariellalgilmore ariellalgilmore mentioned this issue Jan 5, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue Jan 6, 2021
@ariellalgilmore
fix(masthead): add aria-label (#4812)
700ada5 
### Related Ticket(s)

#4773 

### Description

Missing aria label for masthead-search combobox.

### Changelog

**New**

- add aria-label to combobox

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariellalgilmore ariellalgilmore

Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 2 Affects major functionality, has a workaround
Projects
None yet
Milestone
Sprint 21-01
Development

No branches or pull requests
5 participants
@jeffchew @ariellalgilmore @ljcarot @RobertaJHahn @Praveen-sr