chore(components): unify static property for CSS selectors #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the static properties for the CSS selectors, so it aligns to the rest of the codebase (except `stableSelector` for name-compatibility reasons with React). Also removes `sameHeight()` JavaScript code as it'll be replaced with Refs carbon-design-system#4193. Refs carbon-design-system#4144.
asudoh
added
the
package: web components
|
Deploy preview created for package Built with commit: 5d1c8e55996511c2b75d6dae5e42ec74884e3743 |
|
Deploy preview created for package Built with commit: 5d1c8e55996511c2b75d6dae5e42ec74884e3743 |
kennylam
approved these changes
Dec 8, 2020
kennylam
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #4193.
Refs #4144.
Description
Change the static properties for the CSS selectors, so it aligns to the rest of the codebase (except
stableSelectorfor name-compatibility reasons with React).Also removes
sameHeight()JavaScript code as it'll be replaced with #4657.Changelog
Changed
stableSelectorfor name-compatibility reasons with React).Removed
sameHeight()JavaScript code as it'll be replaced with fix(card-group): same height by CSS grid #4657.