card-group: See the purpose of cardGroupItemSelector static property #4144
Assignees
Labels
dev
Needs some dev work
package: web components
Work necessary for the IBM.com Library web components package
priority: high
Milestone
Comments
asudoh
added
dev
29 tasks
asudoh
added a commit
to asudoh/ibm-dotcom-library
that referenced
this issue
Dec 8, 2020
Change the static properties for the CSS selectors, so it aligns to the rest of the codebase (except `stableSelector` for name-compatibility reasons with React). Also removes `sameHeight()` JavaScript code as it'll be replaced with Refs carbon-design-system#4193. Refs carbon-design-system#4144.
kodiakhq bot
pushed a commit
that referenced
this issue
Dec 9, 2020
### Related Ticket(s) Refs #4193. Refs #4144. ### Description Change the static properties for the CSS selectors, so it aligns to the rest of the codebase (except `stableSelector` for name-compatibility reasons with React). Also removes `sameHeight()` JavaScript code as it'll be replaced with #4657. ### Changelog **Changed** - Change the static properties for the CSS selectors, so it aligns to the rest of the codebase (except `stableSelector` for name-compatibility reasons with React). **Removed** - `sameHeight()` JavaScript code as it'll be replaced with #4657.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem
<dds-card-group>hascardGroupItemSelectorstatic property. However, it doesn't seem to be used anywhere.The solution
See if there is an actual use case. If so, rename it to
selectorItemto align the naming convention to other components. Otherwise, remove the static property.The text was updated successfully, but these errors were encountered: