-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(doc): add stable selector to documentation #4654
chore(doc): add stable selector to documentation #4654
Conversation
Deploy preview created for package Built with commit: 42e2de1f4d055975db7752a4fb5d6220356fa957 |
Deploy preview created for package Built with commit: 42e2de1f4d055975db7752a4fb5d6220356fa957 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for jumping in @annawen1 ! Do you want to add stableSelector
static property to horizontal-rule.ts
and headspace.ts
?
packages/web-components/src/components/leadspace/__stories__/README.stories.mdx
Outdated
Show resolved
Hide resolved
…EADME.stories.mdx Co-authored-by: Akira Sudoh <[email protected]>
@asudoh I added documentation for a few more components, can you take a look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @annawen1 for the updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for covering additional things @annawen1!
packages/web-components/src/components/callout-quote/__stories__/README.stories.mdx
Outdated
Show resolved
Hide resolved
@annawen1 Just one more thing - Would you update the snapshot? Thanks! |
…__/README.stories.mdx Co-authored-by: Akira Sudoh <[email protected]>
Related Ticket(s)
Web Components | Add Stable Selectors to Card Link #4356
Web Components | Add Stable Selectors to Horizontal Rule #4362
Web Components | Add Stable Selectors to Leadspace #4365
Web Components | Add Stable Selectors to Image #4364
Web Components | Add Stable Selectors to Quote #4368
Web Components | Add Stable Selectors/Prop Table to Callout Quote #4354
Description
Add stable selector documentation to READMEs.