Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): add stable selector to documentation #4654

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Dec 7, 2020

Related Ticket(s)

Web Components | Add Stable Selectors to Card Link #4356
Web Components | Add Stable Selectors to Horizontal Rule #4362
Web Components | Add Stable Selectors to Leadspace #4365
Web Components | Add Stable Selectors to Image #4364
Web Components | Add Stable Selectors to Quote #4368
Web Components | Add Stable Selectors/Prop Table to Callout Quote #4354

Description

Add stable selector documentation to READMEs.

@annawen1 annawen1 added the package: web components Work necessary for the IBM.com Library web components package label Dec 7, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 7, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 8, 2020

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for jumping in @annawen1 ! Do you want to add stableSelector static property to horizontal-rule.ts and headspace.ts?

@annawen1
Copy link
Member Author

annawen1 commented Dec 8, 2020

@asudoh I added documentation for a few more components, can you take a look? Thanks!

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @annawen1 for the updates!

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for covering additional things @annawen1!

@asudoh
Copy link
Contributor

asudoh commented Dec 8, 2020

@annawen1 Just one more thing - Would you update the snapshot? Thanks!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 8, 2020
@asudoh asudoh merged commit 19ab722 into carbon-design-system:master Dec 9, 2020
@annawen1 annawen1 deleted the chore/hr-stable-selector-docs branch February 10, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants