Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Components | Add Stable Selectors to Image #4364

Closed
jeffchew opened this issue Oct 30, 2020 · 1 comment
Closed

Web Components | Add Stable Selectors to Image #4364

jeffchew opened this issue Oct 30, 2020 · 1 comment
Assignees
@annawen1
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 20-25

Comments

@jeffchew
Copy link
Member

Detailed description

Describe in detail the issue you're having.

Stable selectors and prop table are missing for dds-image

Is this a feature request (new component, new icon), a bug, or a general
issue?

Bug

Is this issue related to a specific component?

dds-image

What did you expect to happen? What happened instead? What would you like to
see changed?

Full documentation on stable selectors.
@jeffchew jeffchew added bug Something isn't working severity 3 Affects minor functionality, has a workaround dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package labels Oct 30, 2020
@jeffchew jeffchew added this to the Sprint 20-25 milestone Oct 30, 2020
@asudoh
Copy link
Contributor

asudoh commented Oct 30, 2020 •
edited
Loading

React <Image> has data-autoid="dds--image__longdescription". It doesn't seems to actually represent what it does, and thus porting it to Web Components doesn't make sense. The recommendation for analytics is using <dds-image> tag.

@annawen1 annawen1 self-assigned this Dec 8, 2020
@annawen1 annawen1 mentioned this issue Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annawen1 annawen1

Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 20-25
Development

No branches or pull requests
4 participants
@asudoh @jeffchew @RobertaJHahn @annawen1