fix(MegaMenu): remove unnecessary role for dropdown menu/megamenu #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annawen1
added
the
package: react
annawen1
requested review from
kennylam,
raphaelamadeu-zz,
andysherman2121,
IgnacioBecerra and
jeffchew
jeffchew
added
the
Ready to merge
|
Deploy preview created for package Built with commit: 14a5c3d0849e85066046500c98f08329299f57d5 |
|
Deploy preview created for package Built with commit: 14a5c3d0849e85066046500c98f08329299f57d5 |
This was referenced Feb 11, 2021
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 12, 2021
### Related Ticket(s) Web component: Mega Menu - "The essentials, Hybrid Cloud" are read as menu options for screen reader users. #5081 ### Description This PR removes the `role='menu'` from the `ul` as it is unnecessary and conflicts with the elements placed in the megamenu/dropdown. PR here from carbon-for-ibm-dotcom where we removed the menu role from our own version of the header menu #4624 The dropdown menu/megamenu shouldn't have the role="menu" applied as listed here: Example Disclosure for Navigation Menus | WAI-ARIA Authoring Practices 1.1 https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-navigation.html <img width="950" alt="Screen Shot 2020-12-03 at 4 25 20 PM" src="https://user-images.githubusercontent.com/54281166/101090282-661c0680-3584-11eb-8dd0-b43ca6f9aa7e.png"> ### Changelog **Changed** - grab the `bx--header-menu` element and remove the `role` attribute <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
…em#5160) ### Related Ticket(s) Web component: Mega Menu - "The essentials, Hybrid Cloud" are read as menu options for screen reader users. carbon-design-system#5081 ### Description This PR removes the `role='menu'` from the `ul` as it is unnecessary and conflicts with the elements placed in the megamenu/dropdown. PR here from carbon-for-ibm-dotcom where we removed the menu role from our own version of the header menu carbon-design-system#4624 The dropdown menu/megamenu shouldn't have the role="menu" applied as listed here: Example Disclosure for Navigation Menus | WAI-ARIA Authoring Practices 1.1 https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-navigation.html <img width="950" alt="Screen Shot 2020-12-03 at 4 25 20 PM" src="https://user-images.githubusercontent.com/54281166/101090282-661c0680-3584-11eb-8dd0-b43ca6f9aa7e.png"> ### Changelog **Changed** - grab the `bx--header-menu` element and remove the `role` attribute <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
React: Issues Mega menu options navigation #4196
Description
The dropdown menu/megamenu shouldn't have the
role="menu"applied as listed here:Example Disclosure for Navigation Menus | WAI-ARIA Authoring Practices 1.1
https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-navigation.html
Changelog
New
Changed
Removed
roleattribute from the<HeaderMenu />component