Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(megamenu): remove menu role for accessibility (carbon-design-syst…
…em#5160) ### Related Ticket(s) Web component: Mega Menu - "The essentials, Hybrid Cloud" are read as menu options for screen reader users. carbon-design-system#5081 ### Description This PR removes the `role='menu'` from the `ul` as it is unnecessary and conflicts with the elements placed in the megamenu/dropdown. PR here from carbon-for-ibm-dotcom where we removed the menu role from our own version of the header menu carbon-design-system#4624 The dropdown menu/megamenu shouldn't have the role="menu" applied as listed here: Example Disclosure for Navigation Menus | WAI-ARIA Authoring Practices 1.1 https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-navigation.html <img width="950" alt="Screen Shot 2020-12-03 at 4 25 20 PM" src="https://user-images.githubusercontent.com/54281166/101090282-661c0680-3584-11eb-8dd0-b43ca6f9aa7e.png"> ### Changelog **Changed** - grab the `bx--header-menu` element and remove the `role` attribute <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
- Loading branch information