Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card-section): introducing web component versions #4471

Conversation

IgnacioBecerra
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra commented Nov 12, 2020

Related Ticket(s)

#3776
#3778

Description

Introducing <dds-card-section-simple> and <dds-card-section-images for Web Components.

Card Section Simple contains the Default and With CTA variations:

Default:
Screen Shot 2020-11-12 at 2 52 27 PM

With CTA:
Screen Shot 2020-11-12 at 2 52 38 PM

Card Section Images only contains the Default variation:
Screen Shot 2020-11-12 at 2 52 51 PM

Changelog

New

  • <dds-card-section-simple> component
  • <dds-card-section-images> component

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 12, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 12, 2020

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress @IgnacioBecerra!

@IgnacioBecerra IgnacioBecerra changed the title feat(card-section): introducing web component version feat(card-section): introducing web component versions Nov 12, 2020
@IgnacioBecerra IgnacioBecerra marked this pull request as ready for review November 12, 2020 22:59
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @IgnacioBecerra!

@IgnacioBecerra IgnacioBecerra added the package: web components Work necessary for the IBM.com Library web components package label Nov 13, 2020
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @IgnacioBecerra

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Nov 13, 2020
@kodiakhq kodiakhq bot merged commit 9272002 into carbon-design-system:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants