Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Component: Develop Card section - simple of the React version - Group 3 #3778

Closed
8 tasks
ibmdotcom-bot opened this issue Aug 28, 2020 · 0 comments
Closed
8 tasks

Web Component: Develop Card section - simple of the React version - Group 3 #3778

ibmdotcom-bot opened this issue Aug 28, 2020 · 0 comments
Assignees
@IgnacioBecerra
Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: medium sprint demo
Milestone
Sprint 20-23

Comments

@ibmdotcom-bot
Copy link
Contributor

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create the Card section - simple

so that I can:
provide ibm.com adopter developers a web component version for every react version available in the ibm.com Library

Additional information

Acceptance criteria

  • Include README for the web component and corresponding styles
  • Create Web Components styles in styles package
  • No custom styles in web-components package
  • Do not create knobs in Storybook that include JSON objects
  • Break out Storybook stories into multiple variation stories, if applicable
  • Create codesandbox example under /packages/web-components/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • A comment is posted in the Prod QA issue, tagging Praveen when development is finished
@ibmdotcom-bot ibmdotcom-bot added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high labels Aug 28, 2020
@ibmdotcom-bot ibmdotcom-bot mentioned this issue Aug 28, 2020
Closed
5 tasks
@RobertaJHahn RobertaJHahn added this to the Sprint 20-19 milestone Aug 28, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 2, 2020
Closed
@RobertaJHahn RobertaJHahn changed the title Web Component: Develop Card section - simple of the React version Web Component: Develop Card section - simple of the React version - Group 3 Sep 9, 2020
@IgnacioBecerra IgnacioBecerra self-assigned this Nov 10, 2020
@IgnacioBecerra IgnacioBecerra mentioned this issue Nov 12, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Nov 13, 2020
@IgnacioBecerra
feat(card-section): introducing web component versions (#4471)
9272002 
### Related Ticket(s)

#3776 
#3778 

### Description

Introducing `<dds-card-section-simple>` and `<dds-card-section-images` for Web Components.

`Card Section Simple` contains the Default and With CTA variations:

Default:
![Screen Shot 2020-11-12 at 2 52 27 PM](https://user-images.githubusercontent.com/24970122/99006527-75fd7900-24f7-11eb-88c6-26e9fa442b1f.png)

With CTA:
![Screen Shot 2020-11-12 at 2 52 38 PM](https://user-images.githubusercontent.com/24970122/99006531-77c73c80-24f7-11eb-92da-4e494ed01ca4.png)


`Card Section Images` only contains the Default variation:
![Screen Shot 2020-11-12 at 2 52 51 PM](https://user-images.githubusercontent.com/24970122/99006534-785fd300-24f7-11eb-8329-03ab64449ce6.png)

### Changelog

**New**

- `<dds-card-section-simple>` component
- `<dds-card-section-images>` component

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnacioBecerra IgnacioBecerra

Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: medium sprint demo
Projects
None yet
Milestone
Sprint 20-23
Development

No branches or pull requests
3 participants
@IgnacioBecerra @RobertaJHahn @ibmdotcom-bot