Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Masthead): add mobile megamenu #4443

Merged
merged 3 commits into from
Nov 11, 2020
Merged

feat(Masthead): add mobile megamenu #4443

merged 3 commits into from
Nov 11, 2020

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Nov 10, 2020 •
edited
Loading

Related Ticket(s)

#3849

Description

Adds megamenu to left nav (mobile view)

Changelog

Changed

  • add nested left nav menu for megamenu links
  • replace ArrowLeft16 with ChevronDown20 for back button

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 10, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4443/index.html

Built with commit: 06ead94ca042ab07653b932fd4d8cd6a64b59592

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 10, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4443/index.html

Built with commit: 06ead94ca042ab07653b932fd4d8cd6a64b59592

asudoh
asudoh approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, nice addition - Thanks @kennylam!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Nov 11, 2020
@kodiakhq kodiakhq bot merged commit c01540f into carbon-design-system:master Nov 11, 2020
@kennylam kennylam deleted the feat/megamenu-mobile-wc branch November 11, 2020 13:11
@jeffchew jeffchew mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @asudoh