Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Components: Develop MegaMenu Mobile version from the React version - Group 3 #3849

Closed
11 tasks
RobertaJHahn opened this issue Sep 2, 2020 · 2 comments
Closed
11 tasks

Web Components: Develop MegaMenu Mobile version from the React version - Group 3 #3849

RobertaJHahn opened this issue Sep 2, 2020 · 2 comments
Assignees
@kennylam
Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package Sprint Must Have
Milestone
Sprint 20-23

Comments

@RobertaJHahn
Copy link

This work is a follow-on to the development work done to create / change the same React version. The React development was managed under epic (#3120)

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create/change the web components MegaMenu mobile version

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance criteria

  • Include README for the web component and corresponding styles
  • Use corresponding React styles in styles package
  • Do not create knobs in Storybook that include JSON objects
  • Break out Storybook stories into multiple variation stories, if applicable
  • Create codesandbox example under /packages/web-components/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • If a design is provided, the Designer is included as a Reviewer in the Pull Request
  • Provide a direct link to the deploy preview for the designer in the Pull Request description
  • A comment is posted in the Design QA issue, tagging Wonil and Roberta, when development is finished
  • The Storybook link is added to the Design QA issue for their testing
  • A comment is posted in the Prod QA issue, tagging Praveen and Chetan, when development is finished
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high labels Sep 2, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-18 milestone Sep 2, 2020
@RobertaJHahn RobertaJHahn changed the title Web Components: Develop MegaMenu Mobile version Web Components: Develop MegaMenu Mobile version from the React version Sep 2, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 2, 2020
Closed
@RobertaJHahn RobertaJHahn mentioned this issue Sep 8, 2020
Closed
5 tasks
@RobertaJHahn
Copy link
Author

@kennylam As we discussed in the meeting earlier today, I am moving this development out to sprint 20-21. Hopefully the Reboot change requests will slow down by then.

@RobertaJHahn RobertaJHahn changed the title Web Components: Develop MegaMenu Mobile version from the React version Web Components: Develop MegaMenu Mobile version from the React version - Group 3 Sep 9, 2020
@kennylam kennylam mentioned this issue Nov 10, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Nov 11, 2020
@kennylam
feat(Masthead): add mobile megamenu (#4443)
c01540f 
### Related Ticket(s)

#3849 

### Description

Adds megamenu to left nav (mobile view)

### Changelog

**Changed**

- add nested left nav menu for megamenu links
- replace `ArrowLeft16` with `ChevronDown20` for back button


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@kennylam
Copy link
Member

@RobertaJHahn @Praveen-sr This is ready for QA http://ibmdotcom-web-components-canary.mybluemix.net/?path=/story/components-masthead--default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package Sprint Must Have
Projects
None yet
Milestone
Sprint 20-23
Development

No branches or pull requests
2 participants
@kennylam @RobertaJHahn