feat(Masthead): React masthead alternate logo and tooltip options #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennylam
changed the title
|
Deploy preview created for package Built with commit: 7ba924ba2bcb7d56e90c2aafb21b71b95663696d |
|
Deploy preview created for package Built with commit: 7ba924ba2bcb7d56e90c2aafb21b71b95663696d |
jeffchew
reviewed
Nov 4, 2020
…am/carbon-for-ibm-dotcom into feat/custom-masthead-logo
jeffchew
approved these changes
Nov 5, 2020
Not yet, I'll set up a Codesandbox with a mock example. |
jeffchew
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
#3906
Description
The masthead now accepts an optional logo options from IBM.com translation files which allows the setting of an alternate IBM logo to use, as well as an optional tooltip when the icon is hovered over. When an alternate logo is used, settings include an expiration date and allow/deny lists for controlling paths on which it can be displayed. The tooltip can be used with both default and alternate logos.
Changelog
New
MastheadLogoservice to determine whether an alternate logo can be used based on values passed in the objectMastheadcomponent now accepts options from IBM.com translations for an alternate logo and tooltipConditionalWrappercomponentChanged