Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Change the IBM logo so that it can be customized #3906

Closed
6 tasks
RobertaJHahn opened this issue Sep 10, 2020 · 0 comments
Closed
6 tasks

React: Change the IBM logo so that it can be customized #3906

RobertaJHahn opened this issue Sep 10, 2020 · 0 comments
Assignees
@kennylam
Labels
dev Needs some dev work Feature request A new adopter requested feature package: react Work necessary for the Carbon for IBM.com react components package priority: low sprint demo Sprint Must Have
Milestone
Sprint 20-22

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Sep 10, 2020 •
edited
Loading

User Story

As a [user role below]:
IBM.com Library developer

I need to:
change the IBM Logo

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance criteria

  • Built as a pure React component/variant
  • Include README for the react component and corresponding styles
  • Add any necessary stable selectors
  • Create codesandbox example under /packages/react/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • A comment is posted in the Prod QA issue, tagging Praveen, when development is finished
@RobertaJHahn RobertaJHahn added adopter: reboot dev Needs some dev work Feature request A new adopter requested feature package: react Work necessary for the Carbon for IBM.com react components package priority: low labels Sep 10, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-19 milestone Sep 10, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 10, 2020
Closed
5 tasks
@RobertaJHahn RobertaJHahn added the package: web components Work necessary for the IBM.com Library web components package label Sep 28, 2020
@RobertaJHahn RobertaJHahn removed the package: web components Work necessary for the IBM.com Library web components package label Oct 19, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Oct 19, 2020
Closed
7 tasks
@kennylam kennylam mentioned this issue Nov 4, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Nov 5, 2020
@kennylam
feat(Masthead): React masthead alternate logo and tooltip options (#4401
0859a21 
)

### Related Ticket(s)

#3906  

### Description

The masthead now accepts an optional logo options from IBM.com translation files which allows the setting of an alternate IBM logo to use, as well as an optional tooltip when the icon is hovered over. When an alternate logo is used, settings include an expiration date and allow/deny lists for controlling paths on which it can be displayed. The tooltip can be used with both default and alternate logos.

### Changelog

**New**

- `MastheadLogo` service to determine whether an alternate logo can be used based on values passed in the object
- React `Masthead` component now accepts options from IBM.com translations for an alternate logo and tooltip
- internal `ConditionalWrapper` component 

**Changed**

- add masthead logo svg dimension styles


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
dev Needs some dev work Feature request A new adopter requested feature package: react Work necessary for the Carbon for IBM.com react components package priority: low sprint demo Sprint Must Have
Projects
None yet
Milestone
Sprint 20-22
Development

No branches or pull requests
2 participants
@kennylam @RobertaJHahn