feat(megamenu): megamenu desktop web component #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 2, 2020 09:18
annawen1
added
package: react
|
Deploy preview created for package Built with commit: 27d6da069b6193ea64808f8a0bdace160952f8cf |
|
Deploy preview created for package Built with commit: 27d6da069b6193ea64808f8a0bdace160952f8cf |
asudoh
reviewed
Nov 3, 2020
packages/web-components/src/components/masthead/masthead-composite.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/masthead-composite.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/masthead-composite.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-category-group.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-category-group.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-left-navigation.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-right-navigation.ts
Outdated
Show resolved
Hide resolved
asudoh
added
package: web components
asudoh
reviewed
Nov 3, 2020
packages/web-components/src/components/masthead/megamenu-right-navigation.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-right-navigation.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-right-navigation.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-right-navigation.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-right-navigation.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/megamenu-category-link.ts
Outdated
Show resolved
Hide resolved
asudoh
reviewed
Nov 4, 2020
packages/web-components/src/components/masthead/masthead-composite.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/masthead-composite.ts
Outdated
Show resolved
Hide resolved
…wen1/ibm-dotcom-library into feat/megamenu-web-component
annawen1
changed the title
added 3 commits
November 6, 2020 13:18
annawen1
requested review from
kennylam,
raphaelamadeu-zz,
andysherman2121,
ariellalgilmore,
guilhermelMoraes,
jeffchew and
IgnacioBecerra
jeffchew
approved these changes
Nov 9, 2020
jeffchew
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Web Component: Develop MegaMenu desktop version from the React version - Group 3 #3284
Description
Megamenu web component
Changelog
New
Changed
hasHighlightsprop from<NavigationGroup />to<RightNavigation />in React to better align with web components