Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Component: Develop MegaMenu desktop version from the React version - Group 3 #3284

Closed
11 tasks done
RobertaJHahn opened this issue Jul 24, 2020 · 2 comments
Closed
11 tasks done

Web Component: Develop MegaMenu desktop version from the React version - Group 3 #3284

RobertaJHahn opened this issue Jul 24, 2020 · 2 comments
Assignees
@annawen1
Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package sprint demo Sprint Must Have
Milestone
Sprint 20-22

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Jul 24, 2020 •
edited by annawen1
Loading

This work is a follow-on to the development work done to create / change the same React version. The React development was managed under epic (#3120)

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create/change the web components MegaMenu desktop version

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance criteria

  • Include README for the web component and corresponding styles
  • Use corresponding React styles in styles package
  • Do not create knobs in Storybook that include JSON objects
  • Break out Storybook stories into multiple variation stories, if applicable
  • Create codesandbox example under /packages/web-components/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • If a design is provided, the Designer is included as a Reviewer in the Pull Request
  • Provide a direct link to the deploy preview for the designer in the Pull Request description
  • A comment is posted in the Design QA issue, tagging Wonil and Roberta, when development is finished
  • The Storybook link is added to the Design QA issue for their testing
  • A comment is posted in the Prod QA issue, tagging Praveen and Chetan, when development is finished
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package labels Jul 24, 2020
@jeffchew jeffchew modified the milestones: Sprint 20-16, Sprint 20-18 Aug 10, 2020
@jeffchew
Copy link
Member

@RobertaJHahn most likely won't get to this one, moving this one out. cc: @annawen1

@RobertaJHahn RobertaJHahn mentioned this issue Aug 10, 2020
Closed
5 tasks
@asudoh asudoh mentioned this issue Sep 1, 2020
Closed
8 tasks
@RobertaJHahn RobertaJHahn changed the title Web Component: Develop MegaMenu MVP Web Component: Develop MegaMenu from the React version Sep 2, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 2, 2020
Closed
@RobertaJHahn RobertaJHahn assigned annawen1 and unassigned annawen1 and kennylam Sep 2, 2020
@RobertaJHahn RobertaJHahn changed the title Web Component: Develop MegaMenu from the React version Web Component: Develop MegaMenu desktop version from the React version Sep 2, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 8, 2020
Closed
5 tasks
@RobertaJHahn
Copy link
Author

@annawen1 Hi Anna, based on our conversation about the fluid nature of the design requests, I have moved this development issue out to sprint 20-21.

@RobertaJHahn RobertaJHahn changed the title Web Component: Develop MegaMenu desktop version from the React version Web Component: Develop MegaMenu desktop version from the React version - Group 3 Sep 9, 2020
@jeffchew jeffchew mentioned this issue Oct 20, 2020
Closed
@annawen1 annawen1 mentioned this issue Nov 3, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Nov 9, 2020
@annawen1
feat(megamenu): megamenu desktop web component (#4384)
a9707fd 
### Related Ticket(s)

Web Component: Develop MegaMenu desktop version from the React version - Group 3 #3284

### Description

Megamenu web component

<img width="1542" alt="Screen Shot 2020-11-05 at 2 15 00 PM" src="https://user-images.githubusercontent.com/54281166/98378874-9b304a00-2014-11eb-8b28-6b7fc6c2beb2.png">

### Changelog

**New**

- megamenu web component

**Changed**
- move `hasHighlights` prop from `<NavigationGroup />` to `<RightNavigation />` in React to better align with web components
- web component styles to the megamenu styles sheet

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annawen1 annawen1

Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package sprint demo Sprint Must Have
Projects
None yet
Milestone
Sprint 20-22
Development

No branches or pull requests
4 participants
@kennylam @jeffchew @RobertaJHahn @annawen1