Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quote): adjust quote grid classes in storybook #4304

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Oct 26, 2020

Related Ticket(s)

Web component: Quote - Spacing between the quote and content is more compared to specs #4127

Description

Adjust the grid classes in the story for Quote and Callout Quote web components to match React version

Changelog

Changed

  • set parent container of storybook frame to no padding
  • adjust grid classes for the quote and callout-quote story

@annawen1 annawen1 added package: web components Work necessary for the IBM.com Library web components package hacktoberfest-accepted labels Oct 26, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @annawen1!

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Oct 27, 2020
@kodiakhq kodiakhq bot merged commit 194756b into carbon-design-system:master Oct 27, 2020
@annawen1 annawen1 deleted the fix/quote-layout branch February 10, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants