Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web component: Quote - Spacing between the quote and content is more compared to specs #4127

Closed
Praveen-sr opened this issue Oct 5, 2020 · 0 comments
Closed

Web component: Quote - Spacing between the quote and content is more compared to specs #4127

Praveen-sr opened this issue Oct 5, 2020 · 0 comments
Assignees
@raphaelamadeu-zz @annawen1
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 20-22

Comments

@Praveen-sr
Copy link

Detailed description

On Mobile, iPhone and android

Issue:

  1. Spacing between the quote and content is more compared to specs
  2. Quote layout, more padding edging of the page

Note: No issue on react version

Additional information

Actual:
image.png

React :
image.png
@Praveen-sr Praveen-sr added bug Something isn't working severity 3 Affects minor functionality, has a workaround labels Oct 5, 2020
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Oct 5, 2020
@RobertaJHahn RobertaJHahn added Airtable Done dev Needs some dev work labels Oct 6, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-21 milestone Oct 6, 2020
@annawen1 annawen1 self-assigned this Oct 20, 2020
This was referenced Oct 26, 2020
Merged
Merged
kodiakhq bot pushed a commit that referenced this issue Oct 27, 2020
@annawen1
fix(quote): adjust quote grid classes in storybook (#4304)
194756b 
### Related Ticket(s)

Web component: Quote - Spacing between the quote and content is more compared to specs #4127

### Description

Adjust the grid classes in the story for Quote and Callout Quote web components to match React version

### Changelog

**Changed**

- set parent container of storybook frame to no padding
- adjust grid classes for the quote and callout-quote story


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kodiakhq bot pushed a commit that referenced this issue Oct 28, 2020
@raphaelamadeu-zz
fix(quote): fixed spacing for closing quote (#4288)
5ffee6f 
### Related Ticket(s)

Web component: Quote - Spacing between the quote and content is more compared to specs #4127

### Description

Fixed spacing difference in Web-components version of Quote.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaelamadeu-zz raphaelamadeu-zz

@annawen1 annawen1

Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 20-22
Development

No branches or pull requests
7 participants
@asudoh @jeffchew @ljcarot @raphaelamadeu-zz @RobertaJHahn @annawen1 @Praveen-sr