fix(Masthead): have nav item render with selected styles in mobile nav #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annawen1
added
the
package: react
annawen1
requested review from
ariellalgilmore,
raphaelamadeu-zz,
andysherman2121,
asudoh,
IgnacioBecerra,
jeffchew and
kennylam
|
Deploy preview created for package Built with commit: 463f2833d19669ce9606196d025dc3d4a9baa6b0 |
|
Deploy preview created for package Built with commit: 463f2833d19669ce9606196d025dc3d4a9baa6b0 |
annawen1
changed the title
ariellalgilmore
approved these changes
Oct 19, 2020
kennylam
added
the
Ready to merge
ariellalgilmore
pushed a commit
to ariellalgilmore/carbon-for-ibm-dotcom
that referenced
this pull request
Oct 22, 2020
carbon-design-system#4259) ### Related Ticket(s) menu item doesn't show active state in hamburg menu in masthead carbon-design-system#4076 ### Description The `LeftNav` menu item wasn't checking with the proper prop, so it wasn't detecting whether to render the nav item as selected in mobile. FIXED: <img width="652" alt="Screen Shot 2020-10-19 at 4 26 13 PM" src="https://user-images.githubusercontent.com/54281166/96508017-fcd87200-1227-11eb-98d1-3b56c314b5a1.png"> ### Changelog **New** - add `titleEnglish` field to the `Nulla quis sem at nibh elementum imperdiet` custom nav item to allow for additional testing **Changed** - check for `rest.selectedMenuItem` in the `LeftNav` and render `#{$prefix}--masthead__l0-nav--selected-item` classname - this is specific for L0 nav items that don't have a menu <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
menu item doesn't show active state in hamburg menu in masthead #4076
Description
The
LeftNavmenu item wasn't checking with the proper prop, so it wasn't detecting whether to render the nav item as selected in mobile.FIXED:
Changelog
New
titleEnglishfield to theNulla quis sem at nibh elementum imperdietcustom nav item to allow for additional testingChanged
rest.selectedMenuItemin theLeftNavand render#{$prefix}--masthead__l0-nav--selected-itemclassname - this is specific for L0 nav items that don't have a menu