forked from carbon-design-system/carbon-for-ibm-dotcom
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(Masthead): have nav item render with selected styles in mobile nav (
carbon-design-system#4259) ### Related Ticket(s) menu item doesn't show active state in hamburg menu in masthead carbon-design-system#4076 ### Description The `LeftNav` menu item wasn't checking with the proper prop, so it wasn't detecting whether to render the nav item as selected in mobile. FIXED: <img width="652" alt="Screen Shot 2020-10-19 at 4 26 13 PM" src="https://user-images.githubusercontent.com/54281166/96508017-fcd87200-1227-11eb-98d1-3b56c314b5a1.png"> ### Changelog **New** - add `titleEnglish` field to the `Nulla quis sem at nibh elementum imperdiet` custom nav item to allow for additional testing **Changed** - check for `rest.selectedMenuItem` in the `LeftNav` and render `#{$prefix}--masthead__l0-nav--selected-item` classname - this is specific for L0 nav items that don't have a menu <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
- Loading branch information
1 parent
883dd74
commit c9a5162
Showing
5 changed files
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters