Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Masthead): add support for megamenu in masthead l1 #4099

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Sep 30, 2020

Related Ticket(s)

React: Change Masthead L1 from behind the feature flag #4010

Description

Add support for megamenu in Masthead L1

Screen Shot 2020-09-30 at 5 42 19 PM

Changelog

New

  • add MegaMenu to the <MastheadL1 />

@annawen1 annawen1 added the package: react Work necessary for the Carbon for IBM.com react components package label Sep 30, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 30, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 30, 2020

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍✅ - Thanks @annawen1!

Update: Can you update the snapshot? Thanks!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Oct 1, 2020
@kodiakhq kodiakhq bot merged commit a7a5837 into carbon-design-system:master Oct 1, 2020
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this pull request Oct 2, 2020
…n-system#4099)

### Related Ticket(s)

React: Change Masthead L1 from behind the feature flag carbon-design-system#4010

### Description

Add support for megamenu in Masthead L1

<img width="1438" alt="Screen Shot 2020-09-30 at 5 42 19 PM" src="https://user-images.githubusercontent.com/54281166/94742861-6a3d6500-0344-11eb-9bc0-389c09f636b0.png">


### Changelog

**New**

- add MegaMenu to the `<MastheadL1 />` 


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@annawen1 annawen1 deleted the feat/megamenu-in-l1-masthead branch February 10, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants