Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Change Masthead L1 from behind the feature flag #4010

Closed
2 tasks
RobertaJHahn opened this issue Sep 18, 2020 · 2 comments
Closed
2 tasks

React: Change Masthead L1 from behind the feature flag #4010

RobertaJHahn opened this issue Sep 18, 2020 · 2 comments
Assignees
@asudoh @annawen1
Labels
dev Needs some dev work feature flag package: react Work necessary for the Carbon for IBM.com react components package Sprint Must Have
Milestone
Sprint 20-20

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Sep 18, 2020 •
edited
Loading

User Story

As a [user role below]:
IBM.com Library developer

I need to:
remove the feature flag from the Masthead L1 component

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance Criteria

  • Updated version of the existing component is available for testing and included in v1.12.0 release
  • A comment is posted in the Prod QA issue, tagging Praveen, when development is finished
@RobertaJHahn RobertaJHahn added dev Needs some dev work feature flag package: react Work necessary for the Carbon for IBM.com react components package labels Sep 18, 2020
This was referenced Sep 21, 2020
Closed
Closed
@RobertaJHahn RobertaJHahn added this to the Sprint 20-20 milestone Sep 28, 2020
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Sep 29, 2020
@asudoh
feat(MastheadL1): graduate masthead L1 from experimental
f3152db 
This change graduates masthead L1 from experimental, making it
available without `DDS_MASTHEAD_L1` feature flag.

`DDS_MASTHEAD_L1` feature flag has been removed.

Also removed the following:

* Eyebrow feature from Masthead L1, given the new design does not seem
  to have the space for eyebrow and the the story that demonstrates the
  eyebrow does not seem to be working.
* Short variant of Masthead L1, given it doesn't seem to be
  demonstrated in storybook.

Refs carbon-design-system#4010.
@asudoh asudoh mentioned this issue Sep 29, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Sep 29, 2020
@asudoh
feat(MastheadL1): graduate masthead L1 from experimental (#4071)
39a6712 
### Related Ticket(s)

Refs #4010.

### Description

This change graduates masthead L1 from experimental, making it available without `DDS_MASTHEAD_L1` feature flag.

`DDS_MASTHEAD_L1` feature flag has been removed.

Also removed the following:

* Eyebrow feature from Masthead L1, given the new design does not seem to have the space for eyebrow and the the story that demonstrates the eyebrow does not seem to be working.
* Short variant of Masthead L1, given it doesn't seem to be demonstrated in storybook.

### Changelog

**New**

- Masthead L1 feature available without a feature flag

**Changed**

- The styles of masthead L1

**Removed**

- `DDS_MASTHEAD_L1` feature flag
- Eyebrow feature from Masthead L1that demonstrates the eyebrow does not seem to be working.
- Short variant of Masthead L1
@annawen1 annawen1 mentioned this issue Oct 1, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Oct 1, 2020
@annawen1
feat(Masthead): add support for megamenu in masthead l1 (#4099)
a7a5837 
### Related Ticket(s)

React: Change Masthead L1 from behind the feature flag #4010

### Description

Add support for megamenu in Masthead L1

<img width="1438" alt="Screen Shot 2020-09-30 at 5 42 19 PM" src="https://user-images.githubusercontent.com/54281166/94742861-6a3d6500-0344-11eb-9bc0-389c09f636b0.png">


### Changelog

**New**

- add MegaMenu to the `<MastheadL1 />` 


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@jeffchew
Copy link
Member

jeffchew commented Oct 2, 2020

@asudoh @annawen1 can we pass this to @Praveen-sr to test?

cc: @RobertaJHahn

ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 2, 2020
@asudoh @ariellalgilmore
feat(MastheadL1): graduate masthead L1 from experimental (carbon-desi…
241317e 
…gn-system#4071)

### Related Ticket(s)

Refs carbon-design-system#4010.

### Description

This change graduates masthead L1 from experimental, making it available without `DDS_MASTHEAD_L1` feature flag.

`DDS_MASTHEAD_L1` feature flag has been removed.

Also removed the following:

* Eyebrow feature from Masthead L1, given the new design does not seem to have the space for eyebrow and the the story that demonstrates the eyebrow does not seem to be working.
* Short variant of Masthead L1, given it doesn't seem to be demonstrated in storybook.

### Changelog

**New**

- Masthead L1 feature available without a feature flag

**Changed**

- The styles of masthead L1

**Removed**

- `DDS_MASTHEAD_L1` feature flag
- Eyebrow feature from Masthead L1that demonstrates the eyebrow does not seem to be working.
- Short variant of Masthead L1
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 2, 2020
@annawen1 @ariellalgilmore
feat(Masthead): add support for megamenu in masthead l1 (carbon-desig…
6ef0c00 
…n-system#4099)

### Related Ticket(s)

React: Change Masthead L1 from behind the feature flag carbon-design-system#4010

### Description

Add support for megamenu in Masthead L1

<img width="1438" alt="Screen Shot 2020-09-30 at 5 42 19 PM" src="https://user-images.githubusercontent.com/54281166/94742861-6a3d6500-0344-11eb-9bc0-389c09f636b0.png">


### Changelog

**New**

- add MegaMenu to the `<MastheadL1 />` 


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@asudoh
Copy link
Contributor

asudoh commented Oct 2, 2020

@jeffchew Right thank you for catching! Updated the QA issue.

@jeffchew jeffchew mentioned this issue Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asudoh asudoh

@annawen1 annawen1

Labels
dev Needs some dev work feature flag package: react Work necessary for the Carbon for IBM.com react components package Sprint Must Have
Projects
None yet
Milestone
Sprint 20-20
Development

No branches or pull requests
4 participants
@asudoh @jeffchew @RobertaJHahn @annawen1