feat(callout): web-component created #3983
Conversation
raphaelamadeu-zz
added
the
package: web components
raphaelamadeu-zz
requested review from
kennylam,
asudoh,
jeffchew and
annawen1
| } | ||
|
|
||
| // eslint-disable-next-line class-methods-use-this | ||
| protected render() { |
There was a problem hiding this comment.
To align to the rest of the codebase:
| protected render() { | |
| render() { |
There was a problem hiding this comment.
I've updated it, thanks for the review!
| <div class="${prefix}--callout__container"> | ||
| <div class="${prefix}--callout__column"> | ||
| <div class="${prefix}--callout__content"> | ||
| <slot /> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
To avoid duplicate elements (host and <div class="${prefix}--callout__container">):
| <div class="${prefix}--callout__container"> | |
| <div class="${prefix}--callout__column"> | |
| <div class="${prefix}--callout__content"> | |
| <slot /> | |
| </div> | |
| </div> | |
| </div> | |
| <div class="${prefix}--callout__column"> | |
| <div class="${prefix}--callout__content"> | |
| <slot /> | |
| </div> | |
| </div> |
Please make sure the host element has the style of .bx--callout__container. Please refer to https://github.com/carbon-design-system/ibm-dotcom-library/blob/v1.11.0-rc.0/packages/web-components/docs/coding-conventions.md#custom-element-itself-as-an-eleement for more details.
There was a problem hiding this comment.
I've updated it, thanks for the review!
There was a problem hiding this comment.
@asudoh We still need the container, in order to maintain the structure seen in the styles package scss
|
Deploy preview created for package Built with commit: a91c9c2bfa88557ee3c2682318d9a3ee59db39ab |
|
@raphaelamadeu there are some build issues, can you take a look?
|
|
Deploy preview created for package Built with commit: a91c9c2bfa88557ee3c2682318d9a3ee59db39ab |
|
@raphaelamadeu looks like there was an impact on the React side, can you doublecheck?
|
@jeffchew They are now resolved. |
jeffchew
added
the
Ready to merge
Related Ticket(s)
#3638
Description
Calloutinternal pattern was created.