Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(callout): drift away from BEM concatenation #3971

Merged
merged 2 commits into from
Sep 16, 2020
Merged

chore(callout): drift away from BEM concatenation #3971

merged 2 commits into from
Sep 16, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Sep 16, 2020

Description

This change to callout style drifts away from BEM concatenation, so the style can be reused with Web Components.

Changelog

Changed

  • A change to callout style drifts away from BEM concatenation, so the style can be reused with Web Components.

@asudoh
chore(callout): drift away from BEM concatenation
aa49367 
This change to callout style drifts away from BEM concatenation, so the
style can be reused with Web Components.
@asudoh asudoh added the package: styles Work necessary for the Carbon for IBM.com styles package label Sep 16, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 16, 2020 •
edited
Loading

Deploy preview created for package "Carbon Expressive":
https://carbon-expressive.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/3971/index.html

Built with commit: 9d22e49fb003d3322e7b21246fe5cb0da43faae1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 16, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/3971/index.html

Built with commit: 9d22e49fb003d3322e7b21246fe5cb0da43faae1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 16, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/3971/index.html

Built with commit: 9d22e49fb003d3322e7b21246fe5cb0da43faae1

@jeffchew
Copy link
Member

@asudoh a PR was just opened by @raphaelamadeu (#3983), is this one still needed?

@asudoh
Copy link
Contributor Author

asudoh commented Sep 16, 2020

Yeah @raphaelamadeu does yours cover <CalloutMedia>? Thanks!

@raphaelamadeu-zz
Copy link
Contributor

@asudoh a PR was just opened by @raphaelamadeu (#3983), is this one still needed?

@jeffchew This one edits the media and data variants of callout, the another pr only handled the default version, so this is still needed.

jeffchew
jeffchew approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for confirming @asudoh !

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Sep 16, 2020
@asudoh
Copy link
Contributor Author

asudoh commented Sep 16, 2020

Thanks @raphaelamadeu for actually confirming! 😉

@kodiakhq kodiakhq bot merged commit 930e8b8 into carbon-design-system:master Sep 16, 2020
@asudoh asudoh deleted the callout-style branch September 16, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
package: styles Work necessary for the Carbon for IBM.com styles package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asudoh @ibmdotcom-bot @jeffchew @raphaelamadeu-zz