fix(masthead-search): no redirect on empty value #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures redirect to dedicated search page upon clicking on the loupe icon happens only when there is a search query in the input box. Refs carbon-design-system#3883.
asudoh
added
the
package: web components
|
Deploy preview created for package Built with commit: 40c240a5fac392be87691aa01d12329e17bd9087 |
|
Deploy preview created for package Built with commit: 40c240a5fac392be87691aa01d12329e17bd9087 |
jeffchew
added
the
Ready to merge
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 14, 2020
### Related Ticket(s) React version fix of #3932 <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: vanilla": Vanilla --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive, React (Expressive) --> <!-- *** "RTL": React (RTL) --> <!-- *** "feature flag": React (experimental) -->
asudoh
added a commit
to asudoh/ibm-dotcom-library
that referenced
this pull request
Oct 14, 2020
Re-applies carbon-design-system#3932 as carbon-design-system#3933 ended up with erasing carbon-design-system#3932. Refs carbon-design-system#3883.
ariellalgilmore
pushed a commit
to ariellalgilmore/carbon-for-ibm-dotcom
that referenced
this pull request
Oct 22, 2020
…gn-system#4227) ### Related Ticket(s) Refs carbon-design-system#3883. ### Description Re-applies carbon-design-system#3932 as carbon-design-system#3933 ended up with erasing carbon-design-system#3932. ### Changelog **Changed** - Re-applies carbon-design-system#3932 as carbon-design-system#3933 ended up with erasing carbon-design-system#3932.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #3883.
Description
This change ensures redirect to dedicated search page upon clicking on
the loupe icon happens only when there is a search query in the input
box.
Changelog
Changed
the loupe icon happens only when there is a search query in the input
box.