Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web component: Masthead - On empty search bar, clicking on search icon, page navigates to search results. #3883

Closed
Praveen-sr opened this issue Sep 9, 2020 · 0 comments
Closed

Web component: Masthead - On empty search bar, clicking on search icon, page navigates to search results. #3883

Praveen-sr opened this issue Sep 9, 2020 · 0 comments
Assignees
@asudoh
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 20-21

Comments

@Praveen-sr
Copy link

Detailed description

Issue: On empty search bar, user clicking on search icon, refreshes the page and navigates to search results.

Additional information

image.png

Landing page:
image.png
@Praveen-sr Praveen-sr added bug Something isn't working severity 3 Affects minor functionality, has a workaround labels Sep 9, 2020
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package Airtable Done labels Sep 9, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-19 milestone Sep 9, 2020
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Sep 14, 2020
@asudoh
fix(masthead-search): no redirect on empty value
45ec3eb 
This change ensures redirect to dedicated search page upon clicking on
the loupe icon happens only when there is a search query in the input
box.

Refs carbon-design-system#3883.
@asudoh asudoh mentioned this issue Sep 14, 2020
Merged
@asudoh asudoh self-assigned this Sep 14, 2020
kodiakhq bot pushed a commit that referenced this issue Sep 14, 2020
@asudoh
fix(masthead-search): no redirect on empty value (#3932)
89f4553 
### Related Ticket(s)

Refs #3883.

### Description

This change ensures redirect to dedicated search page upon clicking on
the loupe icon happens only when there is a search query in the input
box.

### Changelog

**Changed**

- A change to ensure redirect to dedicated search page upon clicking on
the loupe icon happens only when there is a search query in the input
box.
@jeffchew jeffchew mentioned this issue Sep 24, 2020
Closed
@RobertaJHahn RobertaJHahn reopened this Oct 12, 2020
asudoh added a commit to asudoh/ibm-dotcom-library that referenced this issue Oct 14, 2020
@asudoh
fix(masthead-search): re-apply carbon-design-system#3932
e1d7153 
Re-applies carbon-design-system#3932 as carbon-design-system#3933 ended up with erasing carbon-design-system#3932.

Refs carbon-design-system#3883.
@asudoh asudoh mentioned this issue Oct 14, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Oct 14, 2020
@asudoh
fix(masthead-search): re-apply #3932 (#4227)
ee1ece5 
### Related Ticket(s)

Refs #3883.

### Description

Re-applies #3932 as #3933 ended up with erasing #3932.

### Changelog

**Changed**

- Re-applies #3932 as #3933 ended up with erasing #3932.
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 22, 2020
@asudoh @ariellalgilmore
fix(masthead-search): re-apply carbon-design-system#3932 (carbon-desi…
ead78fc 
…gn-system#4227)

### Related Ticket(s)

Refs carbon-design-system#3883.

### Description

Re-applies carbon-design-system#3932 as carbon-design-system#3933 ended up with erasing carbon-design-system#3932.

### Changelog

**Changed**

- Re-applies carbon-design-system#3932 as carbon-design-system#3933 ended up with erasing carbon-design-system#3932.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asudoh asudoh

Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 20-21
Development

No branches or pull requests
5 participants
@asudoh @jeffchew @ljcarot @RobertaJHahn @Praveen-sr