feat(video-player): enable autoplay & load as muted #12150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
requested review from
bruno-amorim,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
m4olivei
changed the title
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andy-blum
approved these changes
Dec 6, 2024
andy-blum
added
the
Ready to merge
|
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
1 similar comment
|
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-7129
Description
Ports a couple of v1 player fixes to v2 that got missed to fix auto-play while maintaining background-video mode:
Work that I've cherry-picked for this PR:
ADCMS-6363
#12070 (3d98787)
#12081 (863dfdc)
Changelog
New
mutedattribute tovideo-player-containerauto-playandmutedvideo player usageChanged
auto-playattribute onvideo-player-containerbackground-videoa reflected boolean attribute all the time.