feat(video-player): enable autoplay & load as muted #12070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview created for package Built with commit: bcaf90f40aae3998ab6e41eeaa12344869b31c74 |
|
Deploy preview created for package Built with commit: bcaf90f40aae3998ab6e41eeaa12344869b31c74 |
|
Deploy preview created for package Built with commit: bcaf90f40aae3998ab6e41eeaa12344869b31c74 |
IgnacioBecerra
approved these changes
Oct 10, 2024
m4olivei
requested changes
Oct 10, 2024
packages/web-components/src/components/video-player/video-player-container.ts
Show resolved
Hide resolved
m4olivei
approved these changes
Oct 15, 2024
m4olivei
added
the
Ready to merge
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
### Related Ticket(s) [ADCMS-7129](https://jsw.ibm.com/browse/ADCMS-7129) ### Description Ports a couple of v1 player fixes to v2 that got missed to fix auto-play while maintaining background-video mode: Work that I've cherry-picked for this PR: [ADCMS-6363](https://jsw.ibm.com/browse/ADCMS-6363) #12070 (3d98787) #12081 (863dfdc) ### Changelog **New** - Adds `muted` attribute to `video-player-container` - Adds storybook examples for `auto-play` and `muted` video player usage **Changed** - Fixes `auto-play` attribute on `video-player-container` - Make `background-video` a reflected boolean attribute all the time. - Fix a regression with auto-play video. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
https://jsw.ibm.com/browse/ADCMS-6363
Description
Fixes the
auto-playattribute to play video on load and adds amutedattribute to load the video with sound fully muted.Changelog
New
mutedattribute tovideo-player-containerauto-playandmutedvideo player usageChanged
auto-playattribute onvideo-player-container