fix(leadspace-breadcrumb): leadspace breadcrumb was missing a max-width #12139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-amorim
requested review from
m4olivei,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andy-blum
approved these changes
Dec 2, 2024
m4olivei
added
the
Ready to merge
deathcave
pushed a commit
to deathcave/carbon-for-ibm-dotcom
that referenced
this pull request
Dec 4, 2024
…th (carbon-design-system#12139) * fix(leadspace-breadcrumb): leadspace breadcrumb was missing a max-width * fixing css issues pointed by our checks --------- Co-authored-by: Andy Blum <[email protected]> Co-authored-by: Matthew Oliveira <[email protected]>
andy-blum
added a commit
that referenced
this pull request
Dec 4, 2024
…th (#12139) * fix(leadspace-breadcrumb): leadspace breadcrumb was missing a max-width * fixing css issues pointed by our checks --------- Co-authored-by: Andy Blum <[email protected]> Co-authored-by: Matthew Oliveira <[email protected]>
Merged
|
Hey there! This issue/pull request was referenced in recently released v2.16.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-6926
Description
When the Leadspace breadcrumbs has a very long text or it has many tiles, the breadcrumb would span full width instead of having a max-width set so it can break into multiple lines.
Changelog
By looking at what we have in v1, we found out that a max-width as missing, I added it back with the same value it had.
max-width added to the slotted breadcrumb element
Thanks all!