Combine Email and Phone into single choice on forms #12127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathcave
requested review from
m4olivei,
bruno-amorim,
marcelojcs and
andy-blum
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sanjitbauli
added
the
test: CDN preview
m4olivei
reviewed
Nov 27, 2024
| @@ -56,6 +56,9 @@ class NoticeChoice extends StableSelectorMixin(LitElement) { | |||
| @property({ type: String, attribute: 'language' }) | |||
| language = 'en'; | |||
|
|
|||
| @property({ type: String, attribute: 'currentLanguage' }) | |||
There was a problem hiding this comment.
Suggested change
| @property({ type: String, attribute: 'currentLanguage' }) | |
| @property({ type: String, attribute: 'current-language' }) |
There was a problem hiding this comment.
This is not yet resolved. Attribute names are snake case by convention, not camel case. Any particular reason to go against the convention for this one out of all the others?
deathcave
force-pushed
the
rebuildNoticeandChoice
branch
from
241ac04 to
32c6e01
Compare
|
Deploy preview created for package Built with commit: 23edf1a16259d74d7381d900f4330aa32331cc65 |
deathcave
force-pushed
the
rebuildNoticeandChoice
branch
3 times, most recently
from
2d90c3a to
df8f757
Compare
deathcave
force-pushed
the
rebuildNoticeandChoice
branch
from
df8f757 to
d489801
Compare
|
Deploy preview created for package Built with commit: 23edf1a16259d74d7381d900f4330aa32331cc65 |
deathcave
force-pushed
the
rebuildNoticeandChoice
branch
2 times, most recently
from
d23c81e to
5219f88
Compare
deathcave
force-pushed
the
rebuildNoticeandChoice
branch
from
caaeca9 to
5fbaf61
Compare
m4olivei
requested changes
Dec 4, 2024
| @@ -56,6 +56,9 @@ class NoticeChoice extends StableSelectorMixin(LitElement) { | |||
| @property({ type: String, attribute: 'language' }) | |||
| language = 'en'; | |||
|
|
|||
| @property({ type: String, attribute: 'currentLanguage' }) | |||
There was a problem hiding this comment.
This is not yet resolved. Attribute names are snake case by convention, not camel case. Any particular reason to go against the convention for this one out of all the others?
m4olivei
approved these changes
Dec 4, 2024
m4olivei
added
the
Ready to merge
|
Follow up PR: #12147 |
andy-blum
pushed a commit
that referenced
this pull request
Dec 4, 2024
### Related Ticket(s) [Noitce & Choice w3 Publisher](https://w3.ibm.com/w3publisher/urx/notice-and-choice-v23) ### Description Notice & Choice is a legally required component to create a form where IBM collects its customer information. This section shows the specific product's legal links, terms, and conditions. Along with this, it collects users' consent regarding communication preferences. ### Changelog **New** - Combine Email and Phone into a single choice on forms **Changed** - Instead of pre-text followed by Email and Phone boxes, combine them into a single checkbox question. Text planned for this is: "I'd like IBM to use my contact details to keep me informed about products, services and offers. More information on how IBM uses data and ways to opt-out can be found in the IBM Privacy Statement.". "Opt-out" and "IBM Privacy Statement would be linked as usual. **Removed** <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
### Related Ticket(s) Follow up to #12127 ### Description Following convention, switch `current-language` attribute to snake case. ### Changelog **Changed** - Changed `currentLanguage` attribute in `<c4d-notice-choice>` component to snake case <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Noitce & Choice w3 Publisher
Description
Notice & Choice is a legally required component to create a form where IBM collects its customer information.
This section shows the specific product's legal links, terms, and conditions. Along with this, it collects users' consent regarding communication preferences.
Changelog
New
Changed
Text planned for this is: "I'd like IBM to use my contact details to keep me informed about products, services and offers. More information on how IBM uses data and ways to opt-out can be found in the IBM Privacy Statement.". "Opt-out" and "IBM Privacy Statement would be linked as usual.
Removed