Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layer/dropdown/combo-box): update stories to Storybook v7 #11318

Merged
merged 7 commits into from
Jan 10, 2024
Merged

feat(layer/dropdown/combo-box): update stories to Storybook v7 #11318

merged 7 commits into from
Jan 10, 2024

Conversation

IgnacioBecerra
Copy link
Contributor

Related Ticket(s)

Closes #11302 #11303 #11300

Description

This PR updates the stories of:

  • Layer
  • Dropdown
  • Combo-box

As well as including with-layer helper component to be included in the preview.js file for Storybook configs.

Changelog

Changed

  • layer, dropdown, and combo-box stories to storybook v7

@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner January 4, 2024 02:50
@IgnacioBecerra IgnacioBecerra requested review from kennylam and sangeethababu9223 and removed request for a team January 4, 2024 02:50
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 4, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11318/index.html

Built with commit: 67bf4ed173b572eb522401ff4a9bffcbdbb6a384

m4olivei
m4olivei reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of small things. My intent here is to get on the same page so we have consistency across the components, since we're going through them all anyway. Sorry for the noise.

packages/carbon-web-components/src/components/combo-box/combo-box.stories.ts Outdated Show resolved Hide resolved
packages/carbon-web-components/src/components/combo-box/combo-box.stories.ts Outdated Show resolved Hide resolved
packages/carbon-web-components/src/components/combo-box/combo-box.stories.ts Outdated Show resolved Hide resolved
packages/carbon-web-components/src/components/dropdown/dropdown.stories.ts Outdated Show resolved Hide resolved
packages/carbon-web-components/src/components/dropdown/dropdown.stories.ts Outdated Show resolved Hide resolved
packages/carbon-web-components/src/components/dropdown/dropdown.stories.ts Show resolved Hide resolved
packages/carbon-web-components/src/components/layer/layer.stories.ts Show resolved Hide resolved
packages/carbon-web-components/src/components/layer/layer.stories.ts Show resolved Hide resolved
packages/carbon-web-components/src/components/layer/layer.stories.ts Outdated Show resolved Hide resolved
kennylam
kennylam approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam
Copy link
Member

kennylam commented Jan 8, 2024

@m4olivei Thanks for the thorough review. Completely agree on consistency across stories. Let me see if I can get the changes from #11248 into this branch to catch linter issues during commit.

m4olivei
m4olivei approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Would especially be nice to get this one in, b/c many stories depend on the <cds-layer> component. For instance @RichKummer and I noticed there were issues with the layers in #11312.

@m4olivei
Copy link
Contributor

m4olivei commented Jan 8, 2024

This looks great!

Would especially be nice to get this one in, b/c many stories depend on the <cds-layer> component. For instance @RichKummer and I noticed there were issues with the layers in #11312.

Scratch this. I was misunderstanding what was needed in other component stories to get layer's fully functioning. There were missing imports in some *.stories.ts files.

@kennylam kennylam merged commit 638da9b into carbon-design-system:feat/cwc-storybook-7-vite Jan 10, 2024
5 of 12 checks passed
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@IgnacioBecerra @kennylam
feat(layer/dropdown/combo-box): update stories to Storybook v7 (carbo…
d7c2e71 
…n-design-system#11318)

* feat(layer): updated to v7

* feat(dropdown): update story

* feat(combo-box): update to v7

* fix(stories): addressed feedback

* fix(markdown): replaced description

---------

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@m4olivei m4olivei m4olivei approved these changes

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components storybook-7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgnacioBecerra @ibmdotcom-bot @kennylam @m4olivei