-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(code-snippet): update story to Storybook v7 #11312
feat(code-snippet): update story to Storybook v7 #11312
Conversation
Deploy preview created for package Built with commit: c47df7a6abf684c2668db09667f8c1af767fbc3b |
As an aside, I noticed a couple of bugs with code snippet here, also on the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @m4olivei !
One question: would there be a quick way to add the layering design from the react Storybook into this? The format in react does a great job of highlighting the layer structure which feels missing here.
Thanks for the review @RichKummer !
Yes! This is now fixed. After your comment I dug in a bit more on this point. I discovered that stories for some components, including code-snippet, we were not fully declaring their dependencies for the layering decoration. This gets exposed with the small set of components that we're presently rendering in this branch of Storybook, as we build back up to the full set. I've corrected that in this and all my other PR's that incorporate the same "With Layer" style stories. |
9da3e3f
to
63004f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
c9193f9
into
carbon-design-system:feat/cwc-storybook-7-vite
…m#11312) * chore(code-snippet): update code-snippet to sb v7 * chore(code-snippet): include storybook layers components * chore(code-snippet): include storybook layers components --------- Co-authored-by: kennylam <[email protected]> Co-authored-by: Ignacio Becerra <[email protected]>
Related Ticket(s)
Closes #11311
Description
Adjustments to code-snippet component to be compatible with Storybook v7.
Changelog
Changed