Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expressive): updated the chevron icon in timepicker as per dropdown #1087

Closed
wants to merge 1 commit into from
Closed

feat(expressive): updated the chevron icon in timepicker as per dropdown #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/styles/scss/themes/expressive/components/_time-picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,9 @@
height: carbon--rem(48px);
width: carbon--rem(85px);
}
.#{$prefix}--time-picker__select {
svg {
height: 100%;
Copy link
Member

@annawen1 annawen1 Jan 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if setting the height changes anything

I think what @oliviaflory was trying to say in the ticket - if you compare the dropdown chevron and the time picker chevron, the time picker chevron looks huge

Screen Shot 2020-01-17 at 11 36 23 AM

Screen Shot 2020-01-17 at 11 36 39 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay got it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annawen1: after looking into this, the Dropdown component is using the lighter version of the chevron icon. And time picker is using a darker version icon. Where these icons are being referenced in the themes.

}
}
}