Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expressive): updated the chevron icon in timepicker as per dropdown #1087

Closed

Conversation

mkothur
Copy link
Contributor

@mkothur mkothur commented Jan 17, 2020

Related Ticket(s)

Expressive theme - #1085

Description

Updated the chevron icon in time picker as per the drop-down component.
image
image

Changelog

Changed

height of chevron inside the select of time-picker.

@mkothur mkothur added the package: styles Work necessary for the Carbon for IBM.com styles package label Jan 17, 2020
@ibmdotcom-bot
Copy link
Contributor

@@ -19,4 +19,9 @@
height: carbon--rem(48px);
width: carbon--rem(85px);
}
.#{$prefix}--time-picker__select {
svg {
height: 100%;
Copy link
Member

@annawen1 annawen1 Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if setting the height changes anything

I think what @oliviaflory was trying to say in the ticket - if you compare the dropdown chevron and the time picker chevron, the time picker chevron looks huge

Screen Shot 2020-01-17 at 11 36 23 AM

Screen Shot 2020-01-17 at 11 36 39 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay got it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annawen1: after looking into this, the Dropdown component is using the lighter version of the chevron icon. And time picker is using a darker version icon. Where these icons are being referenced in the themes.

@annawen1
Copy link
Member

Don't think this PR is necessary anymore as we are switching the icon to use the same one as the <Select /> component which already has expressive styles applied to it.

PR submitted to Carbon: carbon-design-system/carbon#5115

@annawen1 annawen1 closed this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Work necessary for the Carbon for IBM.com styles package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants