Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callout-quote): content off grid #10865

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #10050

Description

Callout Grid - Content was Off Grid.

Changelog

New

  • Added an offset to match the figma

Changed

  • Changed Column width for the grid.

Image 21-08-23 at 11 38 AM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
@sangeethababu9223
@sangeetha Babu
Sangeetha Babu seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 21, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 21, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 21, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 21, 2023

@annawen1 annawen1 changed the title Fix(callout-quote) content off grid fix(callout-quote): content off grid Aug 21, 2023
@annawen1 annawen1 added the package: web components Work necessary for the IBM.com Library web components package label Aug 21, 2023
@RichKummer
Copy link

Hey @sangeethababu9223 ! It looks like the callout quote has the proper spacing on @sm breakpoint. When I'm looking at larger breakpoints, it doesn't seem like the text is flush with the column.

@md
Screenshot 2023-08-21 at 1 13 53 PM

@xlg
Screenshot 2023-08-21 at 1 14 01 PM

The expected behavior is that the text (quote, attribution below, and link) are flush with the column edge, unless the component is @sm. The opening quote mark should then overhang the text on the left. Compare with the specs below:

@md
Screenshot 2023-08-21 at 1 20 46 PM

@xlg
Screenshot 2023-08-21 at 1 23 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Callout quote]: Content off grid
4 participants