Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Callout quote]: Content off grid #10050

Closed
2 tasks done
Tracked by #10542 ...
RichKummer opened this issue Feb 14, 2023 · 1 comment · Fixed by #10869
Closed
2 tasks done
Tracked by #10542 ...

[Callout quote]: Content off grid #10050

RichKummer opened this issue Feb 14, 2023 · 1 comment · Fixed by #10869
Assignees
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed

Comments

@RichKummer
Copy link

RichKummer commented Feb 14, 2023

Description

The callout quote component's quote text, attribution, and link content are not aligned in the live version. See the design specs for proper grid alignment.

Seeing the misalignment from @max through @sm.

@xlg
Screen Shot 2023-02-14 at 11 14 59 AM

@md
Screen Shot 2023-02-14 at 11 15 21 AM

@sm
Screen Shot 2023-02-14 at 11 16 40 AM

Compare with Figma design specs
Screen Shot 2023-02-14 at 11 19 57 AM
Screen Shot 2023-02-14 at 11 22 26 AM

Component(s) impacted

callout quote

Browser

Chrome, Safari, Firefox

Carbon for IBM.com version

v1.28.0

Severity

Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.

Application/website

C4IBM.com

Package

@carbon/ibmdotcom-react, @carbon/ibmdotcom-web-components, @carbon/web-components, @carbon/ibmdotcom-styles

CodeSandbox example

https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/web-components/examples/codesandbox/components/callout-quote

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@RichKummer RichKummer added bug Something isn't working dev Needs some dev work labels Feb 14, 2023
@RichKummer RichKummer added the package: styles Work necessary for the Carbon for IBM.com styles package label Feb 14, 2023
@kennylam kennylam added the severity 4 Affects minor functionality, no workaround needed label Feb 20, 2023
@stale
Copy link

stale bot commented May 27, 2023

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label May 27, 2023
@annawen1 annawen1 moved this to Backlog in Carbon for IBM.com Jun 12, 2023
@annawen1 annawen1 added package: web components Work necessary for the IBM.com Library web components package and removed package: styles Work necessary for the Carbon for IBM.com styles package labels Aug 9, 2023
@sangeethababu9223 sangeethababu9223 self-assigned this Aug 16, 2023
@sangeethababu9223 sangeethababu9223 moved this from Backlog to Doing in Carbon for IBM.com Aug 16, 2023
@oliviaflory oliviaflory moved this from Doing to Review in Carbon for IBM.com Aug 21, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 4 Affects minor functionality, no workaround needed
Projects
Archived in project
8 participants