Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Change Language Selector from behind the feature flag #4049

Closed
2 tasks
RobertaJHahn opened this issue Sep 24, 2020 · 0 comments
Closed
2 tasks

React: Change Language Selector from behind the feature flag #4049

RobertaJHahn opened this issue Sep 24, 2020 · 0 comments
Assignees
@kennylam
Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package Sprint Must Have
Milestone
Sprint 20-20

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Sep 24, 2020 •
edited
Loading

User Story

As a [user role below]:
IBM.com Library developer

I need to:
remove the feature flag from the Language Selector component

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance Criteria

  • Updated version of the existing component is available for testing and included in v1.12.0 release
  • A comment is posted in the Prod QA issue, tagging Praveen, when development is finished
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package Sprint Must Have labels Sep 24, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-20 milestone Sep 24, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 24, 2020
Closed
5 tasks
@kennylam kennylam mentioned this issue Sep 28, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Sep 29, 2020
@kennylam
feat(footer): graduating language selector to production ready (#4069)
55cd218 
### Related Ticket(s)

#3665, #4049 

### Description

Removes footer language-only dropdown from behind feature flag.

### Changelog

**New**

- footer stories with `languageOnly` variant.

**Changed**

- update README

**Removed**

- feature flag for language dropdown

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 2, 2020
@kennylam @ariellalgilmore
feat(footer): graduating language selector to production ready (carbo…
361147f 
…n-design-system#4069)

### Related Ticket(s)

carbon-design-system#3665, carbon-design-system#4049 

### Description

Removes footer language-only dropdown from behind feature flag.

### Changelog

**New**

- footer stories with `languageOnly` variant.

**Changed**

- update README

**Removed**

- feature flag for language dropdown

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@jeffchew jeffchew mentioned this issue Oct 8, 2020
Closed
@RobertaJHahn RobertaJHahn mentioned this issue Dec 10, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package Sprint Must Have
Projects
None yet
Milestone
Sprint 20-20
Development

No branches or pull requests
2 participants
@kennylam @RobertaJHahn