Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error showing for the Footer language selector when in DotcomShell #3665

Closed
jeffchew opened this issue Aug 20, 2020 · 0 comments
Closed

Error showing for the Footer language selector when in DotcomShell #3665

jeffchew opened this issue Aug 20, 2020 · 0 comments
Assignees
@kennylam
Labels
adopter support bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package severity 2 Affects major functionality, has a workaround
Milestone
Sprint 20-20

Comments

@jeffchew
Copy link
Member

Detailed description

Describe in detail the issue you're having.

When clicking the language selector (not locale modal button), an error shows up:

Screen Shot 2020-08-20 at 9 55 11 AM

Is this issue related to a specific component?

Footer language selector

Steps to reproduce the issue

  1. Go to React experimental (https://ibmdotcom-react-experimental.mybluemix.net)
  2. Go to Dotcomshell
  3. Enable "languageOnly"
  4. Click the language selector dropdown

Additional Information

  • The standalone footer appears to work
@jeffchew jeffchew added bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package dev Needs some dev work adopter support adopter: Docs/KC used when component or pattern will be used by this adopter labels Aug 20, 2020
@jeffchew jeffchew mentioned this issue Aug 20, 2020
Merged
@RobertaJHahn RobertaJHahn added severity 2 Affects major functionality, has a workaround Airtable Done and removed adopter: Docs/KC used when component or pattern will be used by this adopter labels Aug 26, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-19 milestone Aug 26, 2020
@kennylam kennylam mentioned this issue Sep 28, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Sep 29, 2020
@kennylam
feat(footer): graduating language selector to production ready (#4069)
55cd218 
### Related Ticket(s)

#3665, #4049 

### Description

Removes footer language-only dropdown from behind feature flag.

### Changelog

**New**

- footer stories with `languageOnly` variant.

**Changed**

- update README

**Removed**

- feature flag for language dropdown

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 2, 2020
@kennylam @ariellalgilmore
feat(footer): graduating language selector to production ready (carbo…
361147f 
…n-design-system#4069)

### Related Ticket(s)

carbon-design-system#3665, carbon-design-system#4049 

### Description

Removes footer language-only dropdown from behind feature flag.

### Changelog

**New**

- footer stories with `languageOnly` variant.

**Changed**

- update README

**Removed**

- feature flag for language dropdown

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@jeffchew jeffchew mentioned this issue Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
adopter support bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package severity 2 Affects major functionality, has a workaround
Projects
None yet
Milestone
Sprint 20-20
Development

No branches or pull requests
6 participants
@kennylam @jeffchew @ariellalgilmore @ljcarot @JennySanchez @RobertaJHahn