Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

fix(DropdownV2): match experimental spec #2093

Merged
merged 26 commits into from
Mar 28, 2019
Merged

fix(DropdownV2): match experimental spec #2093

merged 26 commits into from
Mar 28, 2019

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 25, 2019 •
edited
Loading

Closes IBM/carbon-components-react#2022

depends on
carbon-design-system/carbon#2203
carbon-design-system/carbon#2206
carbon-design-system/carbon#2212

This PR incorporates feedback from the March 2019 dropdown component audit

Changelog

Changed

  • Integrate v10 listbox styles

Removed

  • type prop for inline listbox components (requires refactoring of multiselect and combobox as well)

@emyarod emyarod added this to the v10.0-rc1 milestone Mar 25, 2019
@netlify
Copy link

netlify bot commented Mar 25, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit f5e719d

https://deploy-preview-2093--carbon-components-react.netlify.com

@emyarod emyarod modified the milestones: v10.0-rc1, v10-update Mar 25, 2019
@emyarod emyarod marked this pull request as ready for review March 26, 2019 14:22
@emyarod
Copy link
Member Author

emyarod commented Mar 26, 2019

carbon-design-system/carbon#2203 only addressed the overflow issue for the trigger button label 🤦‍♂️

  • need overflow styles on menu options

  • inline list box menu options also need reduced side margins to match dropdown spec

image

@emyarod emyarod force-pushed the 2022-match-dropdown-to-experimental-spec branch from 2a6bb36 to daca338 Compare March 26, 2019 18:54
laurenmrice
laurenmrice suggested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment •
edited by emyarod
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Just one change: The top rule line in the drawer is flush next to the focus state. It

Screen Shot 2019-03-26 at 3 25 10 PM

needs to not be there when the focus border is active.

This was referenced Mar 26, 2019
Closed
Merged
@emyarod emyarod force-pushed the 2022-match-dropdown-to-experimental-spec branch from daca338 to 661c4cf Compare March 27, 2019 17:05
@emyarod
Copy link
Member Author

emyarod commented Mar 27, 2019

tests are failing because of improperly formatted issue templates https://github.com/IBM/carbon-components-react/issues/2098

blocked until #2099 is merged in

@emyarod
Revert "refactor(ListBox): deprecate type prop"
65b2978 
This reverts commit 642c01a.
@emyarod
Revert "test: update snapshots and inline variant test"
e507ddc 
This reverts commit d98db03.
@emyarod
docs(ListBox): add propType
3913929
@emyarod
fix(Dropdown): use listbox light and invalid style
e2b91c6
@emyarod
docs(DropdownV2): change options list placeholder
0c83e5b
@emyarod
fix(Dropdown): remove breaking changes flag
ae1c6b0
@emyarod
test: update snapshots
bd39568
@emyarod
chore: bump carbon-components version
65bb27d
@emyarod
chore: bump carbon-components version
aa39bdd
@emyarod
chore: bump carbon-components version
dab328e
@emyarod
chore: bump carbon-components version
0b13ae3
@emyarod
fix(ListBoxMenuItem): add conditional for v10
3af80fa
@emyarod
fix(DropdownV2): add disabled class
826f143
@emyarod
fix(DropdownV2): add light class
d233cef
@emyarod
chore: update snapshots
cb24d1d
@emyarod
refactor(ListBoxMenuItem): remove unneeded attrs
50b733c
@emyarod emyarod force-pushed the 2022-match-dropdown-to-experimental-spec branch from 4e44770 to 50b733c Compare March 28, 2019 18:34
@emyarod emyarod requested a review from joshblack March 28, 2019 18:37
asudoh
asudoh reviewed Mar 28, 2019
View reviewed changes
src/components/DropdownV2/DropdownV2.js Outdated
);
return title || helper ? (
<>
<div className={wrapperClasses}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the change here - Wanted to see it's tested in v9. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it in v9 but I will rope it off as we don't have a wrapper in v9

@emyarod emyarod requested a review from asudoh March 28, 2019 18:43
@emyarod emyarod merged commit a7c293c into carbon-design-system:master Mar 28, 2019
@emyarod emyarod deleted the 2022-match-dropdown-to-experimental-spec branch March 28, 2019 19:27
@carbon-bot
Copy link

🎉 This PR is included in version 6.113.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emyarod emyarod mentioned this pull request Apr 4, 2019
Merged
@emyarod emyarod mentioned this pull request May 9, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@joshblack joshblack joshblack approved these changes

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
status: ready for review 👀 status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emyarod @carbon-bot @asudoh @joshblack @laurenmrice