-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components):Light version IconSwitch and DateTimePicker #1582
Conversation
Deploy preview for carbon-addons-iot-react ready! Built with commit 315f655 https://deploy-preview-1582--carbon-addons-iot-react.netlify.app |
Deploy preview for carbon-addons-iot-react ready! Built with commit c5c2adb https://deploy-preview-1582--carbon-addons-iot-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I just have two smaller change requests
…design-system/carbon-addons-iot-react into light-version-components chore(merge): merge from branch.
@dianatran18 could you review and approve these two style variations? |
Both are good to go with the light variant 👍 The IconSwitch is carried over in our new kit with the light variant option, but I haven't carried over the DateTimePicker yet. Although, I opened this issue before to make some stylistic updates to the IconSwitch (one being the light variant so that's good) on issue #1536. Could we get those updates in as well? |
@cgirani I think this is good to merge once @davidicus's comments are addressed. Let me know if you'd like me to take a look. |
…ns-iot-react into light-version-components
…ns-iot-react into light-version-components
Looks good 👍🏻 |
🎉 This PR is included in version 2.131.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #1581
Summary
eg.
Change List (commits, features, bugs, etc)
Acceptance Test (how to verify the PR)