Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components):Light version IconSwitch and DateTimePicker #1582

Merged
merged 19 commits into from
Oct 8, 2020

Conversation

cgirani
Copy link
Collaborator

@cgirani cgirani commented Sep 8, 2020

Closes #1581

Summary

  • Adding css class for light version of component IconSwitch and DateTimePicker
  • Adding id as a required key in preset object, since offset can be equal sometimes and more than one entry would appear as selected

eg.
image

Change List (commits, features, bugs, etc)

  • feat(iconswitch): IconSwitch light version
  • feat(datetimepicker): DateTimePicker light version
  • fix(datetimepicker): use id as a preset selector

Acceptance Test (how to verify the PR)

  • Make sure the components still works as expected.

@netlify
Copy link

netlify bot commented Sep 8, 2020

Deploy preview for carbon-addons-iot-react ready!

Built with commit 315f655

https://deploy-preview-1582--carbon-addons-iot-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 8, 2020

Deploy preview for carbon-addons-iot-react ready!

Built with commit c5c2adb

https://deploy-preview-1582--carbon-addons-iot-react.netlify.app

@cgirani cgirani changed the title Light version components feat(components):Light version components Sep 8, 2020
@cgirani cgirani changed the title feat(components):Light version components feat(components):Light version IconSwitch and DateTimePicker Sep 8, 2020
Copy link
Contributor

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I just have two smaller change requests

src/components/DateTimePicker/_date-time-picker.scss Outdated Show resolved Hide resolved
src/components/DateTimePicker/DateTimePicker.jsx Outdated Show resolved Hide resolved
src/components/DateTimePicker/DateTimePicker.jsx Outdated Show resolved Hide resolved
src/components/DateTimePicker/DateTimePicker.jsx Outdated Show resolved Hide resolved
src/components/DateTimePicker/DateTimePicker.jsx Outdated Show resolved Hide resolved
@tay1orjones
Copy link
Member

tay1orjones commented Sep 17, 2020

@dianatran18 could you review and approve these two style variations? IconSwitch and DateTimePicker. Are these available in sketch and documented on the internal website?

@dianasanborn
Copy link
Collaborator

Both are good to go with the light variant 👍

The IconSwitch is carried over in our new kit with the light variant option, but I haven't carried over the DateTimePicker yet.

Although, I opened this issue before to make some stylistic updates to the IconSwitch (one being the light variant so that's good) on issue #1536. Could we get those updates in as well?

@tay1orjones
Copy link
Member

@cgirani I think this is good to merge once @davidicus's comments are addressed. Let me know if you'd like me to take a look.

@davidicus davidicus changed the base branch from master to 1659-prettier-reconfiguration October 8, 2020 17:31
@davidicus davidicus changed the base branch from 1659-prettier-reconfiguration to master October 8, 2020 17:31
@bryancboyd
Copy link
Collaborator

Looks good 👍🏻

@tay1orjones tay1orjones merged commit d5f34c0 into master Oct 8, 2020
@tay1orjones tay1orjones deleted the light-version-components branch October 8, 2020 19:38
@tay1orjones
Copy link
Member

🎉 This PR is included in version 2.131.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IconSwitch/DateTimePicker]: Support light version
6 participants