Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon content switcher] Styling enhancement #1536

Closed
dianasanborn opened this issue Aug 25, 2020 · 2 comments · Fixed by #2819
Closed

[Icon content switcher] Styling enhancement #1536

dianasanborn opened this issue Aug 25, 2020 · 2 comments · Fixed by #2819
Assignees
Labels
design reconciliation Align latest designs to PAL components available OOTB for React and Angular status: needs design 🎨 Items that require the input of a visual/ux designer type: enhancement 💡 New feature or request val: 2

Comments

@dianasanborn
Copy link
Collaborator

dianasanborn commented Aug 25, 2020

Looking to update the icon content switcher styling slightly to match what Carbon has for their content switcher

Updates:

  • Update color of hover and selected states to match Carbon's content switcher
  • remove stroke around default state (although that is in design on the PAL site but I'm not seeing it in code?)
  • Round corners on the left and right end buttons
  • Build in light variant
  • Can we also update the placement of the tooltip that shows up to match what the icon button does?

Carbon style specs: https://www.carbondesignsystem.com/components/content-switcher/style

Specs:

Icon content switcher

@JordanWSmith15
Copy link
Collaborator

This one has been around a while, and the design has changed in the meantime: carbon-design-system/carbon#6745

@dianasanborn
Copy link
Collaborator Author

Beat me to it!

We actually have a few issues open this month to update the spec for this in our internal repo:

For the low contrast variation, this was an effort by a designer to contribute it back to the Carbon team. The low contrast version has been approved by Carbon, so we wanted to reflect the additional variation in our PAL too. The end goal is to just contribute this back to Carbon to support an icon version of the content switcher, which has an open ticket from a while ago: carbon-design-system/carbon#6982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design reconciliation Align latest designs to PAL components available OOTB for React and Angular status: needs design 🎨 Items that require the input of a visual/ux designer type: enhancement 💡 New feature or request val: 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants