fix: shorten form acquisition URLs - WD-6294

[pedoch]

Done

• Shorten acquisition URLs on submitted forms as described by the task: WD-6294
  • The task is to ensure the acquisition URLs are not longer than 255 characters, if they are the fbclid and gclid parameters should be removed.

QA

• Go to any page with a form and add any of these query parameters to the url: ?utm_source=facebook_ad&utm_medium=cpc&utm_campaign=7018e000000Lrr2AAC&fbclid=IwAR15h71YCzbtXmItLpTWGKvX6LGlbBNrsYAsoq-IEJiF9SYy_aDXgpsIqn0_aem_AbSMY4GVnRtIgih_p0mTaKvNZH6T3Qy73plm8KSqnZJXAsol_n1J440OjNsdU2s6-a0urWDolTPSE0nv3SYoY3jU
  or
  ?utm_source=facebook_ad&utm_medium=cpc&utm_campaign=7018e000000Lrr2AAC&gclid=IwAR15h71YCzbtXmItLpTWGKvX6LGlbBNrsYAsoq-IEJiF9SYy_aDXgpsIqn0_aem_AbSMY4GVnRtIgih_p0mTaKvNZH6T3Qy73plm8KSqnZJXAsol_n1J440OjNsdU2s6-a0urWDolTPSE0nv3SYoY3jU
  • For example: https://ubuntu-com-13244.demos.haus/contact-us would become https://ubuntu-com-13244.demos.haus/contact-us?utm_source=facebook_ad&utm_medium=cpc&utm_campaign=7018e000000Lrr2AAC&fbclid=IwAR15h71YCzbtXmItLpTWGKvX6LGlbBNrsYAsoq-IEJiF9SYy_aDXgpsIqn0_aem_AbSMY4GVnRtIgih_p0mTaKvNZH6T3Qy73plm8KSqnZJXAsol_n1J440OjNsdU2s6-a0urWDolTPSE0nv3SYoY3jU
• After submitting the form go to marketo and check that the aquisition url is shortened.

Quick link you can test

• Engage page

Issue / Card

• WD-6294

[webteam-app]

Demo starting at https://ubuntu-com-13244.demos.haus

[codecov]

Codecov Report

Merging #13244 (1a1ed4d) into main (e019fbd) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Current head 1a1ed4d differs from pull request most recent head 068368e. Consider uploading reports for the commit 068368e to get more accurate results

@@           Coverage Diff           @@
##             main   #13244   +/-   ##
=======================================
  Coverage   74.43%   74.43%           
=======================================
  Files         107      107           
  Lines        2840     2840           
  Branches      948      948           
=======================================
  Hits         2114     2114           
  Misses        702      702           
  Partials       24       24           

[laszlokajtar]

lgtm

[pedoch]

@carkod do you mind taking a look at this PR when you have the time? I ask since you commented on the previous two which I closed.

[pedoch]

@laszlokajtar were you able to QA the PR (submitting a form and checking the acquisition URL on marketo)?

[laszlokajtar]

@pedoch oh sorry, i misunderstood and wasn't sure that's required at this point.

tested now on two ubuntu.com URLs and neither test submissions had acquisition url. when i submitted a form without URL parameters, the acqusition URL was correctly identified.

[laszlokajtar]

@pedoch on checking, it seems that the enrichment submit is not successful when there are URLs parameters. the submit arrives with the non-enrichment form (e.g. 3230) but doesn't for the enrichment one (1257)

[pedoch]

@pedoch oh sorry, i misunderstood and wasn't sure that's required at this point.

@laszlokajtar I only asked if you were to QA because I'm not able to navigate marketo properly to check the result of the submission.

@pedoch on checking, it seems that the enrichment submit is not successful when there are URLs parameters. the submit arrives with the non-enrichment form (e.g. 3230) but doesn't for the enrichment one (1257)

If I understand correctly, the acquisition URL is dropped by marketo when it has URL parameters?

[carkod]

Submission of engage page forms used to work in the demo, but now it's breaking? May be related to what @laszlokajtar is saying.

[carkod]

https://ubuntu.com/engage/case-study-gmo-pepabo submission form is not working.

[pedoch]

@carkod the demo seems to be up now. I replace the link with an engage page that works (the previous one seems to have a problem on prod too, may be from marketo) so could you check this again. Thank you!

[carkod]

Ideally, we should create a demo on jp.ubuntu.com pointing to this PR so we can test it, because ubuntu.com doesn't need acquisition url.

Optionally, would you be willing to write a unit test for the shorten_acquisition_url function? Basically just your QA in a test.

[pedoch]

@carkod Sure, I can write a unit test for the shorten_acquisition_url function, and I'll look into creating a demo on jp.ubuntu.com that points at this PR

[carkod]

Left a comment in the demo PR

[pedoch]

@carkod I was finally able to access sentry and I figured out what the problem was and fixed it. You can test the jp.ubuntu.com submission again.

[carkod]

Amazing work, thanks. LGTM