Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point engage form submission to PR for testing #468

Conversation

pedoch
Copy link

@pedoch pedoch commented Nov 2, 2023

This PR is just for testing purposes. DO NOT MERGE!

@pedoch pedoch requested a review from carkod November 2, 2023 12:37
@pedoch pedoch force-pushed the WD-6294-modify-jp-ubuntu-com-cn-ubuntu-com-acquisition-url-to-respect-length-limit branch from 547f0dd to 3157c4c Compare November 2, 2023 12:38
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #468 (19c1611) into main (050a154) will increase coverage by 0.42%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head 19c1611 differs from pull request most recent head 3157c4c. Consider uploading reports for the commit 3157c4c to get more accurate results

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   78.15%   78.57%   +0.42%     
==========================================
  Files           8        8              
  Lines         238      238              
==========================================
+ Hits          186      187       +1     
+ Misses         52       51       -1     
Flag Coverage Δ
python 78.57% <ø> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@carkod
Copy link
Contributor

carkod commented Nov 2, 2023

I tried this engage page and it failed to submit with a bad request.

A 400 bad request looks like it's /marketo/submit doesn't like the payload.

@pedoch
Copy link
Author

pedoch commented Nov 2, 2023

@carkod I checked the pod, it seems the error occurs at the point of submission to marketo. I tried checking sentry for the exact error but it seems I don't have access anymore.

@pedoch
Copy link
Author

pedoch commented Nov 2, 2023

This PR was open to test the market submission on this PR: canonical/ubuntu.com#13244

The PR has been merged so this can be closed.

@pedoch pedoch closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants