task/WD-6598 #13211

lizzochek · 2023-10-05T15:19:29Z

Done

Updated link and icon for 23.10

QA

Check out this feature branch
Run the site using the command ./run serve or dotrun
View the site locally in your web browser at: http://0.0.0.0:8001/
- Be sure to test on mobile, tablet and desktop screen sizes

Issue / Card

WD-6598

Fixes #

Screenshots

Help

QA steps - Commit guidelines

…load page

* Fix subscription status chips * Remove juju install section * Address comments * Refresh /download/raspberry-pi * Hide images on smaller screens * Update with UX suggestions * Remove whitespace from th tag * Update raspberry-pi 5 image --------- Co-authored-by: minkyngkm <[email protected]> Co-authored-by: Carlos Wu Fei <[email protected]> Co-authored-by: Carlos Wu <[email protected]> Co-authored-by: Min Kim <[email protected]>

webteam-app · 2023-10-05T15:19:32Z

Demo starting at https://ubuntu-com-13211.demos.haus

templates/download/desktop/index.html

carkod · 2023-10-05T15:24:11Z

releases.yaml

+  short_version: "23.10"
+  full_version: "23.10"
  core_version: "22"
  release_date: "April 2023"
-  eol: "January 2024"
+  eol: "July 2024"
  past_eol_date: false
-  release_notes_url: "https://discourse.ubuntu.com/t/lunar-lobster-release-notes/31910"
+  release_notes_url: "https://discourse.ubuntu.com/t/mantic-minotaur-release-notes/35534"
 lts:


You don't need any of these changes, we still haven't released 23.10, this will change on October 12

The copy doc had those changes

Liza, you need to point your PR to 23-10-release branch instead of main. Then you will see that these changes are already applied there.

carkod · 2023-10-05T15:24:38Z

templates/download/desktop/index.html

@@ -65,7 +65,7 @@ <h2>Ubuntu {{ releases.latest.full_version }}</h2>
      <div class="u-align--center u-sv4">
        {{
          image (
-          url="https://assets.ubuntu.com/v1/3a32d136-Lobster_circular.png",
+          url="https://assets.ubuntu.com/v1/d708a347-mantic-minotaur-logo.png",


You may need design review for this.

codecov · 2023-10-05T15:33:17Z

Codecov Report

Merging #13211 (14e5204) into 23-10-release (6dff7df) will increase coverage by 0.09%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           23-10-release   #13211      +/-   ##
=================================================
+ Coverage          75.30%   75.40%   +0.09%     
=================================================
  Files                106      106              
  Lines               2847     2862      +15     
  Branches             932      942      +10     
=================================================
+ Hits                2144     2158      +14     
- Misses               681      682       +1     
  Partials              22       22

see 1 file with indirect coverage changes

carkod · 2023-10-05T15:47:57Z

package.json

@@ -101,7 +101,7 @@
    "flickity": "^3.0.0",
    "formik": "2.2.9",
    "intl-tel-input": "17.0.18",
-    "postcss": "8.4.5",
+    "postcss": "8.4.31",


This change shouldn't be here

carkod · 2023-10-05T16:07:03Z

templates/download/desktop/index.html

@@ -79,7 +79,7 @@ <h2>Ubuntu {{ releases.latest.full_version }}</h2>
        <script>performance.mark("Download (Desktop) button rendered")</script>
      </p>
      <p>
-        <a href="https://cdimage.ubuntu.com/releases/lunar/release/ubuntu-23.04-desktop-legacy-amd64.iso" onclick="dataLayer.push({'event' : 'GAEvent', 'eventCategory' : 'Download', 'eventAction' : 'Desktop', 'eventLabel' : '{{ releases.latest.short_version }} legacy installer', 'eventValue' : undefined });">Download {{ releases.latest.short_version }} (Legacy Desktop Installer)</a>
+        <a href="https://cdimage.ubuntu.com/releases/lunar/release/ubuntu-{{ releases.latest.short_version }}-desktop-legacy-amd64.iso" onclick="dataLayer.push({'event' : 'GAEvent', 'eventCategory' : 'Download', 'eventAction' : 'Desktop', 'eventLabel' : '{{ releases.latest.short_version }} legacy installer', 'eventValue' : undefined });">Download {{ releases.latest.short_version }} (Legacy Desktop Installer)</a>


This is the only change you need. To confirm with @anthonydillon

akbarkz · 2023-10-06T05:39:23Z

releases.yaml

+  short_version: "23.10"
+  full_version: "23.10"
  core_version: "22"
  release_date: "April 2023"
-  eol: "January 2024"
+  eol: "July 2024"
  past_eol_date: false
-  release_notes_url: "https://discourse.ubuntu.com/t/lunar-lobster-release-notes/31910"
+  release_notes_url: "https://discourse.ubuntu.com/t/mantic-minotaur-release-notes/35534"
 lts:


Liza, you need to point your PR to 23-10-release branch instead of main. Then you will see that these changes are already applied there.

akbarkz · 2023-10-06T08:09:48Z

@lizzochek looks like you didn't rebase your branch agains latest changes. Please rebase it against upstream 23-10-release. As you can see now you have 18 changed files.

akbarkz · 2023-10-06T08:11:18Z

@lizzochek also, it seems like you create a branch in the parent repository, while as you need to create your branch from your forked repository.
Here you can see that both branches are from parent repo:

If you create a branch from your forked repo it will look like this:

Akbar Abdrakhmanov and others added 6 commits October 2, 2023 16:27

change 23.04 to 23.10 on RISC-V download page

82551a6

add live installer download button to VisionFive 2 tab on RISC-V down…

1c18ce3

…load page

fix name of the link in VisionFive 2 tab of RISC-V download page

7b30d69

make Mantic Minotaur the latest release

11a4e3f

update latest release's mascot image

d4c12ba

lizzochek added Review: QA needed Review: UX needed labels Oct 5, 2023

carkod reviewed Oct 5, 2023

View reviewed changes

templates/download/desktop/index.html Outdated Show resolved Hide resolved

carkod reviewed Oct 5, 2023

View reviewed changes

carkod requested a review from anthonydillon October 5, 2023 15:26

lizzochek changed the base branch from main to 23-10-release October 5, 2023 15:30

lizzochek added the Review: Design needed label Oct 5, 2023

lizzochek requested a review from lyubomir-popov October 5, 2023 15:31

carkod added the Review: Code needed label Oct 5, 2023

carkod reviewed Oct 5, 2023

View reviewed changes

lizzochek changed the base branch from 23-10-release to main October 5, 2023 15:55

carkod reviewed Oct 5, 2023

View reviewed changes

akbarkz requested changes Oct 6, 2023

View reviewed changes

[WD-6598] - update release assets and links

14e5204

lizzochek force-pushed the task/WD-6598 branch from d1ac09d to 14e5204 Compare October 6, 2023 07:32

lizzochek changed the base branch from main to 23-10-release October 6, 2023 07:33

akbarkz force-pushed the 23-10-release branch from 6dff7df to ea38ebc Compare October 6, 2023 07:43

lizzochek requested a review from akbarkz October 6, 2023 08:04

lizzochek closed this Oct 6, 2023

lizzochek deleted the task/WD-6598 branch October 6, 2023 08:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

task/WD-6598 #13211

task/WD-6598 #13211

lizzochek commented Oct 5, 2023 •

edited

Loading

webteam-app commented Oct 5, 2023

carkod Oct 5, 2023

lizzochek Oct 5, 2023

akbarkz Oct 6, 2023

carkod Oct 5, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading

carkod Oct 5, 2023

carkod Oct 5, 2023

akbarkz Oct 6, 2023

akbarkz commented Oct 6, 2023

akbarkz commented Oct 6, 2023 •

edited

Loading

task/WD-6598 #13211

task/WD-6598 #13211

Conversation

lizzochek commented Oct 5, 2023 • edited Loading

Done

QA

Issue / Card

Screenshots

Help

webteam-app commented Oct 5, 2023

carkod Oct 5, 2023

Choose a reason for hiding this comment

lizzochek Oct 5, 2023

Choose a reason for hiding this comment

akbarkz Oct 6, 2023

Choose a reason for hiding this comment

carkod Oct 5, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 5, 2023 • edited Loading

Codecov Report

carkod Oct 5, 2023

Choose a reason for hiding this comment

carkod Oct 5, 2023

Choose a reason for hiding this comment

akbarkz Oct 6, 2023

Choose a reason for hiding this comment

akbarkz commented Oct 6, 2023

akbarkz commented Oct 6, 2023 • edited Loading

lizzochek commented Oct 5, 2023 •

edited

Loading

codecov bot commented Oct 5, 2023 •

edited

Loading

akbarkz commented Oct 6, 2023 •

edited

Loading