-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh /download/raspberry-pi #13191
Conversation
Demo starting at https://ubuntu-com-13191.demos.haus/download/raspberry-pi |
Codecov Report
@@ Coverage Diff @@
## 23-10-release #13191 +/- ##
==============================================
Coverage 75.30% 75.30%
==============================================
Files 106 106
Lines 2847 2847
Branches 932 932
==============================================
Hits 2144 2144
Misses 681 681
Partials 22 22 |
@lyubomir-popov Could you help with the this please? The image in question has some white padding around it, making it look misaligned. |
Could you take another look @lyubomir-popov, some of the deign has changed to fit the content better |
yes but first can I ask, why are we using images here at all? At this size they hardly add anything meaningful. the only scenario they could be useful in is if you’re not sure which board you have but you know what it looks like - at this size though, it would be very difficult to make the right choice based on the tiny image. Unless I’m missing something, I would suggest dropping the images and the maintenance they require. What do you think @juanruitina |
I do think the images here do provide a sense of the form factor, even at this size: it might not be noticeable in all cases, but it is in the case of Raspberry Pi 400, Zero, and to some extent the CM; images set these three apart from the others. I'd keep them. |
@akbarkz Can you have another look please? |
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.5 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.5...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
This reverts commit 6dff7df.
* Fix subscription status chips * Remove juju install section * Address comments * Refresh /download/raspberry-pi * Hide images on smaller screens * Update with UX suggestions * Remove whitespace from th tag * Update raspberry-pi 5 image --------- Co-authored-by: minkyngkm <[email protected]> Co-authored-by: Carlos Wu Fei <[email protected]> Co-authored-by: Carlos Wu <[email protected]> Co-authored-by: Min Kim <[email protected]>
Done
QA
./run serve
ordotrun
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-6491