Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh /download/raspberry-pi #13191

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Refresh /download/raspberry-pi #13191

merged 14 commits into from
Oct 4, 2023

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Oct 2, 2023

Done

  • Refresh /download/raspberry-pi based off of copydoc changes

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-6491

@webteam-app
Copy link

webteam-app commented Oct 2, 2023

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #13191 (8d7f64d) into 23-10-release (d4c12ba) will not change coverage.
Report is 1 commits behind head on 23-10-release.
The diff coverage is n/a.

❗ Current head 8d7f64d differs from pull request most recent head 269bb9f. Consider uploading reports for the commit 269bb9f to get more accurate results

@@              Coverage Diff               @@
##           23-10-release   #13191   +/-   ##
==============================================
  Coverage          75.30%   75.30%           
==============================================
  Files                106      106           
  Lines               2847     2847           
  Branches             932      932           
==============================================
  Hits                2144     2144           
  Misses               681      681           
  Partials              22       22           

@akbarkz
Copy link
Contributor

akbarkz commented Oct 4, 2023

Screen Shot 2023-10-04 at 09 44 40
Looks like the selected image is not aligned with the other images above, it's moved slightly to the right.

@petesfrench
Copy link
Contributor Author

Screen Shot 2023-10-04 at 09 44 40 Looks like the selected image is not aligned with the other images above, it's moved slightly to the right.

@lyubomir-popov Could you help with the this please? The image in question has some white padding around it, making it look misaligned.

@petesfrench
Copy link
Contributor Author

Could you take another look @lyubomir-popov, some of the deign has changed to fit the content better

@lyubomir-popov
Copy link
Contributor

yes but first can I ask, why are we using images here at all? At this size they hardly add anything meaningful. the only scenario they could be useful in is if you’re not sure which board you have but you know what it looks like - at this size though, it would be very difficult to make the right choice based on the tiny image. Unless I’m missing something, I would suggest dropping the images and the maintenance they require. What do you think @juanruitina

@juanruitina
Copy link
Contributor

juanruitina commented Oct 4, 2023

I do think the images here do provide a sense of the form factor, even at this size: it might not be noticeable in all cases, but it is in the case of Raspberry Pi 400, Zero, and to some extent the CM; images set these three apart from the others. I'd keep them.

@lyubomir-popov
Copy link
Contributor

raspberry-pi-5
image cropped properly ^. Please pass 3x width/height to cloudinary as it makes everything very blurred on retina screens

@petesfrench
Copy link
Contributor Author

@akbarkz Can you have another look please?

@petesfrench petesfrench changed the base branch from main to 23-10-release October 4, 2023 12:00
@petesfrench petesfrench merged commit 6dff7df into 23-10-release Oct 4, 2023
@petesfrench petesfrench deleted the wd-6491 branch October 4, 2023 14:43
petesfrench added a commit that referenced this pull request Oct 4, 2023
akbarkz pushed a commit that referenced this pull request Oct 6, 2023
* Fix subscription status chips

* Remove juju install section

* Address comments

* Refresh /download/raspberry-pi

* Hide images on smaller screens

* Update with UX suggestions

* Remove whitespace from th tag

* Update raspberry-pi 5 image

---------

Co-authored-by: minkyngkm <[email protected]>
Co-authored-by: Carlos Wu Fei <[email protected]>
Co-authored-by: Carlos Wu <[email protected]>
Co-authored-by: Min Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants